Skip to content

Commit e99fa4b

Browse files
committed
Merged in [17419] from rjsparks@nostrum.com:
Don't warn about idcutoff when the cutoff is after the meeting starts. Fixes ietf-tools#2907. - Legacy-Id: 17422 Note: SVN reference [17419] has been migrated to Git commit edc41a8
2 parents 84dca63 + edc41a8 commit e99fa4b

2 files changed

Lines changed: 39 additions & 0 deletions

File tree

ietf/submit/forms.py

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -93,6 +93,11 @@ def set_cutoff_warnings(self):
9393
cutoff_00_str = cutoff_00.strftime("%Y-%m-%d %H:%M %Z")
9494
cutoff_01_str = cutoff_01.strftime("%Y-%m-%d %H:%M %Z")
9595
reopen_str = reopen.strftime("%Y-%m-%d %H:%M %Z")
96+
97+
# Workaround for IETF107. This would be better handled by a refactor that allowed meetings to have no cutoff period.
98+
if cutoff_01 >= reopen:
99+
return
100+
96101
if cutoff_00 == cutoff_01:
97102
if now.date() >= (cutoff_00.date() - meeting.idsubmit_cutoff_warning_days) and now.date() < cutoff_00.date():
98103
self.cutoff_warning = ( 'The last submission time for Internet-Drafts before %s is %s.<br/><br/>' % (meeting, cutoff_00_str))

ietf/submit/tests.py

Lines changed: 34 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1008,6 +1008,40 @@ def test_blackout_access(self):
10081008
q = PyQuery(r.content)
10091009
self.assertEqual(len(q('input[type=file][name=txt]')), 1)
10101010

1011+
def test_no_blackout_at_all(self):
1012+
url = urlreverse('ietf.submit.views.upload_submission')
1013+
1014+
meeting = Meeting.get_current_meeting()
1015+
meeting.date = datetime.date.today()+datetime.timedelta(days=7)
1016+
meeting.save()
1017+
meeting.importantdate_set.filter(name_id='idcutoff').delete()
1018+
meeting.importantdate_set.create(name_id='idcutoff', date=datetime.date.today()+datetime.timedelta(days=7))
1019+
r = self.client.get(url)
1020+
self.assertEqual(r.status_code,200)
1021+
q = PyQuery(r.content)
1022+
self.assertEqual(len(q('input[type=file][name=txt]')), 1)
1023+
1024+
meeting = Meeting.get_current_meeting()
1025+
meeting.date = datetime.date.today()
1026+
meeting.save()
1027+
meeting.importantdate_set.filter(name_id='idcutoff').delete()
1028+
meeting.importantdate_set.create(name_id='idcutoff', date=datetime.date.today())
1029+
r = self.client.get(url)
1030+
self.assertEqual(r.status_code,200)
1031+
q = PyQuery(r.content)
1032+
self.assertEqual(len(q('input[type=file][name=txt]')), 1)
1033+
1034+
meeting = Meeting.get_current_meeting()
1035+
meeting.date = datetime.date.today()-datetime.timedelta(days=1)
1036+
meeting.save()
1037+
meeting.importantdate_set.filter(name_id='idcutoff').delete()
1038+
meeting.importantdate_set.create(name_id='idcutoff', date=datetime.date.today()-datetime.timedelta(days=1))
1039+
r = self.client.get(url)
1040+
self.assertEqual(r.status_code,200)
1041+
q = PyQuery(r.content)
1042+
self.assertEqual(len(q('input[type=file][name=txt]')), 1)
1043+
1044+
10111045
def submit_bad_file(self, name, formats):
10121046
rev = ""
10131047
group = None

0 commit comments

Comments
 (0)