Skip to content

Commit e941296

Browse files
committed
@register.simple_tag now (in Django 1.9) needs explicit mark_safe() (or format_html() which invokes mark_safe()). Fixed one case which needed this.
- Legacy-Id: 12779
1 parent 2d02ec9 commit e941296

1 file changed

Lines changed: 4 additions & 3 deletions

File tree

ietf/doc/templatetags/ballot_icon.py

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -37,6 +37,7 @@
3737
from django import template
3838
from django.core.urlresolvers import reverse as urlreverse
3939
from django.db.models import Q
40+
from django.utils.html import format_html
4041
from django.utils.safestring import mark_safe
4142

4243
from ietf.ietfauth.utils import user_is_person, has_role
@@ -99,10 +100,10 @@ def sort_key(t):
99100
my_blocking = True
100101
break
101102

102-
res = ['<a %s href="%s" data-toggle="modal" data-target="#modal-%d" title="IESG positions (click to show more)" class="ballot-icon"><table' % (
103+
res = [ format_html('<a %s href="%s" data-toggle="modal" data-target="#modal-%d" title="IESG positions (click to show more)" class="ballot-icon"><table', *(
103104
right_click_string,
104105
urlreverse("ietf.doc.views_doc.ballot_popup", kwargs=dict(name=doc.name, ballot_id=ballot.pk)),
105-
ballot.pk,)]
106+
ballot.pk,))]
106107
if my_blocking:
107108
res.append(' class="is-blocking" ')
108109
res.append('>')
@@ -130,7 +131,7 @@ def sort_key(t):
130131
# See http://getbootstrap.com/javascript/#modals-usage
131132
res.append('<div id="modal-%d" class="modal fade" tabindex="-1" role="dialog" aria-hidden="true"><div class="modal-dialog modal-lg"><div class="modal-content"></div></div></div>' % ballot.pk)
132133

133-
return "".join(res)
134+
return mark_safe("".join(res))
134135

135136
@register.filter
136137
def ballotposition(doc, user):

0 commit comments

Comments
 (0)