Skip to content

Commit e8e2db5

Browse files
committed
Merged in [15347] from kivinen@iki.fi:
Add review request date to the top. Add tooltips for drafts versions providing the date they were sumbmitted. Fixes ietf-tools#2218. Commit ready for merge. - Legacy-Id: 15382 Note: SVN reference [15347] has been migrated to Git commit dcabfc8
2 parents 803b239 + dcabfc8 commit e8e2db5

2 files changed

Lines changed: 3 additions & 2 deletions

File tree

ietf/doc/views_review.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -380,7 +380,7 @@ def __init__(self, review_req, *args, **kwargs):
380380

381381
doc = self.review_req.doc
382382

383-
known_revisions = NewRevisionDocEvent.objects.filter(doc=doc).order_by("time", "id").values_list("rev", flat=True)
383+
known_revisions = NewRevisionDocEvent.objects.filter(doc=doc).order_by("time", "id").values_list("rev", "time", flat=False)
384384

385385
revising_review = review_req.state_id not in ["requested", "accepted"]
386386

@@ -391,7 +391,7 @@ def __init__(self, review_req, *args, **kwargs):
391391
]
392392

393393
self.fields["reviewed_rev"].help_text = mark_safe(
394-
" ".join("<a class=\"rev label label-default\">{}</a>".format(r)
394+
" ".join("<a class=\"rev label label-default\" title=\"{1:%Y-%m-%d}\">{0}</a>".format(*r)
395395
for r in known_revisions))
396396

397397
self.fields["result"].queryset = self.fields["result"].queryset.filter(reviewteamsettings__group=review_req.team)

ietf/templates/doc/review/complete_review.html

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -17,6 +17,7 @@ <h1>{% if revising_review %}Revise{% else %}Complete{% endif %} review<br>
1717
<p>
1818
<div><strong>Review type:</strong> {{ review_req.team.acronym }} - {{ review_req.type }} review </div>
1919
<div><strong>Requested version for review:</strong> {{ review_req.requested_rev|default:"Current" }} </div>
20+
<div><strong>Requsted:</strong> {{ review_req.time|date:"Y-m-d" }} </div>
2021
<div><strong>Reviewer:</strong> {{ review_req.reviewer.person.name }}</div>
2122
</p>
2223

0 commit comments

Comments
 (0)