Skip to content

Commit e87dd6b

Browse files
committed
Merged in [17797] from rjsparks@nostrum.com:
Better use of group type in interim announcement tools. Fixes ietf-tools#2989. - Legacy-Id: 17809 Note: SVN reference [17797] has been migrated to Git commit 9ba71be
2 parents 2d3910f + 9ba71be commit e87dd6b

3 files changed

Lines changed: 7 additions & 9 deletions

File tree

ietf/meeting/helpers.py

Lines changed: 4 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -401,7 +401,7 @@ def get_announcement_initial(meeting, is_change=False):
401401
addrs = gather_address_lists('interim_announced',group=group).as_strings()
402402
initial['to'] = addrs.to
403403
initial['cc'] = addrs.cc
404-
initial['frm'] = settings.INTERIM_ANNOUNCE_FROM_EMAIL
404+
initial['frm'] = settings.INTERIM_ANNOUNCE_FROM_EMAIL_PROGRAM if group.type_id=='program' else settings.INTERIM_ANNOUNCE_FROM_EMAIL_DEFAULT
405405
if in_person:
406406
desc = 'Interim'
407407
else:
@@ -410,12 +410,9 @@ def get_announcement_initial(meeting, is_change=False):
410410
change = ' CHANGED'
411411
else:
412412
change = ''
413-
if group.type.slug == 'rg':
414-
type = 'RG'
415-
elif group.type.slug == 'wg' and group.state.slug == 'bof':
413+
type = group.type.slug.upper()
414+
if group.type.slug == 'wg' and group.state.slug == 'bof':
416415
type = 'BOF'
417-
else:
418-
type = 'WG'
419416
initial['subject'] = '{name} ({acronym}) {type} {desc} Meeting: {date}{change}'.format(
420417
name=group.name,
421418
acronym=group.acronym,
@@ -547,7 +544,7 @@ def send_interim_cancellation_notice(meeting):
547544
session = meeting.session_set.first()
548545
group = session.group
549546
(to_email, cc_list) = gather_address_lists('interim_cancelled',group=group)
550-
from_email = settings.INTERIM_ANNOUNCE_FROM_EMAIL
547+
from_email = settings.INTERIM_ANNOUNCE_FROM_EMAIL_PROGRAM if group.type_id=='program' else settings.INTERIM_ANNOUNCE_FROM_EMAIL_DEFAULT
551548
subject = '{group} ({acronym}) {type} Interim Meeting Cancelled (was {date})'.format(
552549
group=group.name,
553550
acronym=group.acronym,

ietf/settings.py

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -764,7 +764,8 @@ def skip_unreadable_post(record):
764764
IDSUBMIT_ANNOUNCE_LIST_EMAIL = 'i-d-announce@ietf.org'
765765

766766
# Interim Meeting Tool settings
767-
INTERIM_ANNOUNCE_FROM_EMAIL = 'IESG Secretary <iesg-secretary@ietf.org>'
767+
INTERIM_ANNOUNCE_FROM_EMAIL_DEFAULT = 'IESG Secretary <iesg-secretary@ietf.org>'
768+
INTERIM_ANNOUNCE_FROM_EMAIL_PROGRAM = 'IAB Executive Administrative Manager <execd@iab.org>'
768769
VIRTUAL_INTERIMS_REQUIRE_APPROVAL = False
769770
INTERIM_SESSION_MINIMUM_MINUTES = 30
770771
INTERIM_SESSION_MAXIMUM_MINUTES = 300

ietf/templates/meeting/interim_announcement.txt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{% load ietf_filters %}{% if is_change %}MEETING DETAILS HAVE CHANGED. SEE LATEST DETAILS BELOW.
22

3-
{% endif %}The {{ group.name }} ({{ group.acronym }}) {% if group.type.slug == "rg" %}Research Group{% elif group.state.slug == "active" %}Working Group{% elif group.state.slug == 'bof' %}BOF{% endif %} will hold
3+
{% endif %}The {{ group.name }} ({{ group.acronym }}) {% if group.type.slug == 'wg' and group.state.slug == 'bof' %}BOF{% else %}{{group.type.name}}{% endif %} will hold
44
{% if meeting.session_set.count == 1 %}a{% if meeting.city %}n {% else %} virtual {% endif %}interim meeting on {{ meeting.date }} from {{ meeting.schedule.assignments.first.timeslot.time | date:"H:i" }} to {{ meeting.schedule.assignments.first.timeslot.end_time | date:"H:i" }} {{ meeting.time_zone}}{% if meeting.time_zone != 'UTC' %} ({{ meeting.schedule.assignments.first.timeslot.utc_start_time | date:"H:i" }} to {{ meeting.schedule.assignments.first.timeslot.utc_end_time | date:"H:i" }} UTC){% endif %}.
55
{% else %}a multi-day {% if not meeting.city %}virtual {% endif %}interim meeting.
66

0 commit comments

Comments
 (0)