Handle expiring the last call of status change documents. Be more robust about errors when expiring last calls. Fixes ietf-tools#1911. Commit ready for merge.

 - Legacy-Id: 10811

Author: rjsparks

ietf/bin/expire-last-calls

@@ -14,5 +14,8 @@ from ietf.doc.lastcall import *
 
 drafts = get_expired_last_calls()
 for doc in drafts:
-    expire_last_call(doc)
-    syslog.syslog("Expired last call for %s (id=%s)" % (doc.file_tag(), doc.pk))
+    try:
+        expire_last_call(doc)
+        syslog.syslog("Expired last call for %s (id=%s)" % (doc.file_tag(), doc.pk))
+    except Exception as e:
+        syslog.syslog(syslog.LOG_ERR, "ERROR: Failed to expire last call for %s (id=%s)" % (doc.file_tag(), doc.pk))

ietf/doc/mails.py

@@ -357,7 +357,9 @@ def extra_automation_headers(doc):
     return extra
 
 def email_last_call_expired(doc):
-    text = "IETF Last Call has ended, and the state has been changed to\n%s." % doc.get_state("draft-iesg").name
+    if not doc.type_id in ['draft','statchg']:
+        return
+    text = "IETF Last Call has ended, and the state has been changed to\n%s." % doc.get_state("draft-iesg" if doc.type_id == 'draft' else "statchg").name
     addrs = gather_address_lists('last_call_expired',doc=doc)
 
     send_mail(None,