Refactor generic person API

 - Legacy-Id: 15264

Author: rpcross

ietf/api/urls.py

@@ -20,8 +20,8 @@
     url(r'^meeting/session/video/url$', meeting_views.api_set_session_video_url),
     url(r'^submit/?$', submit_views.api_submit),
     url(r'^iesg/position', views_ballot.api_set_position),
-    url(r'^export/person/$', api_views.PersonExportView.as_view()),
-    url(r'^export/person/generic', api_views.GenericPersonExportView.as_view()),
+    url(r'^export/personal-information/$', api_views.PersonExportView.as_view()),
+    url(r'^v2/person/person', api_views.GenericPersonView.as_view()),
 ]
 
 # Additional (standard) Tastypie endpoints

ietf/api/views.py

@@ -79,21 +79,17 @@ def get(self, request):
 
 
 @method_decorator((csrf_exempt, require_api_key, role_required('Secretariat')), name='dispatch')
-class GenericPersonExportView(DetailView, JsonExportMixin):
+class GenericPersonView(DetailView, JsonExportMixin):
     model = Person
 
     def err(self, code, text):
         return HttpResponse(text, status=code, content_type='text/plain')
 
     def post(self, request):
-        if 'email' not in request.POST:
-            return self.err(400, "Missing email parameter")
-        email_address = request.POST.get('email')
-        try:
-            email = Email.objects.get(address=email_address)
-        except Email.DoesNotExist:
-            return self.err(404, "Email not found '%s'" % (email_address, ))
-        person = email.person
-        expand = ['user']
-        return self.json_view(request, filter={'id': person.id}, expand=expand)
+        querydict = request.POST.copy()
+        querydict.pop('apikey', None)
+        expand = querydict.pop('_expand', [])
+        if not querydict:
+            return self.err(400, "No filters provided")
 
+        return self.json_view(request, filter=querydict.dict(), expand=expand)

ietf/person/models.py

@@ -293,7 +293,7 @@ def salt():
 # Manual maintenance: List all endpoints that use @require_api_key here
 PERSON_API_KEY_ENDPOINTS = [
     ("/api/iesg/position", "/api/iesg/position"),
-    ("/api/export/person/generic", "/api/export/person/generic"),
+    ("/api/v2/person/person", "/api/v2/person/person"),
     ("/api/meeting/session/video/url", "/api/meeting/session/video/url"),
 ]