Skip to content

Commit e569bf3

Browse files
committed
Improve the syslog output for the IANA review email script, also
handle error cases more graceful - Legacy-Id: 4880
1 parent 2ab4161 commit e569bf3

1 file changed

Lines changed: 9 additions & 3 deletions

File tree

ietf/bin/iana-review-email

Lines changed: 9 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -15,13 +15,19 @@ management.setup_environ(settings)
1515
syslog.openlog(os.path.basename(__file__), syslog.LOG_PID, syslog.LOG_LOCAL0)
1616

1717
from ietf.sync.iana import *
18+
from ietf.doc.models import Document
1819

1920
msg = sys.stdin.read()
2021

21-
syslog.syslog("Reading IANA review email")
22-
2322
doc_name, review_time, by, comment = parse_review_email(msg)
24-
add_review_comment(doc_name, review_time, by, comment)
23+
24+
syslog.syslog(u"Read IANA review email for %s at %s by %s" % (doc_name, review_time, by))
2525

2626
if by.name == "(System)":
2727
syslog.syslog("WARNING: person responsible for email does not have a IANA role")
28+
29+
try:
30+
add_review_comment(doc_name, review_time, by, comment)
31+
except Document.DoesNotExist:
32+
syslog.syslog("ERROR: unknown document %s" % doc_name)
33+

0 commit comments

Comments
 (0)