Skip to content

Commit e1f6917

Browse files
committed
xslugify the last name part when constructing a name for the review document
- Legacy-Id: 12147
1 parent 9a3996a commit e1f6917

2 files changed

Lines changed: 4 additions & 4 deletions

File tree

ietf/doc/views_review.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@
2323
setup_reviewer_field)
2424
from ietf.review import mailarch
2525
from ietf.utils.fields import DatepickerDateField
26-
from ietf.utils.text import strip_prefix
26+
from ietf.utils.text import strip_prefix, xslugify
2727
from ietf.utils.textupload import get_cleaned_text_file_content
2828
from ietf.utils.mail import send_mail
2929

@@ -410,7 +410,7 @@ def complete_review(request, name, request_id):
410410
form.cleaned_data["reviewed_rev"],
411411
review_req.team.acronym,
412412
review_req.type.slug,
413-
review_req.reviewer.person.ascii_parts()[3],
413+
xslugify(review_req.reviewer.person.ascii_parts()[3]),
414414
datetime.date.today().isoformat(),
415415
]
416416
if i > 1:

ietf/review/import_from_review_tool.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@
2222
from ietf.group.models import Group, Role, RoleName
2323
from ietf.person.models import Person, Email, Alias
2424
from ietf.doc.models import Document, DocAlias, ReviewRequestDocEvent, NewRevisionDocEvent, DocTypeName, State
25-
from ietf.utils.text import strip_prefix
25+
from ietf.utils.text import strip_prefix, xslugify
2626
import argparse
2727
from unidecode import unidecode
2828

@@ -565,7 +565,7 @@ def fix_docname(docname):
565565
review_req.reviewed_rev,
566566
review_req.team.acronym,
567567
review_req.type_id,
568-
review_req.reviewer.person.ascii_parts()[3],
568+
xslugify(unicode(review_req.reviewer.person.ascii_parts()[3])),
569569
completion_time.date().isoformat(),
570570
]
571571
if i > 1:

0 commit comments

Comments
 (0)