Skip to content

Commit e01ba98

Browse files
committed
Introduce generic states, not fully incorporated yet, and rename tag
name model - Legacy-Id: 3616
1 parent f6261a9 commit e01ba98

11 files changed

Lines changed: 908 additions & 109 deletions

File tree

ietf/idrfc/expire.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@
1010
from ietf.utils.mail import send_mail, send_mail_subj
1111
from ietf.idrfc.utils import log_state_changed, add_document_comment
1212
from doc.models import Document, DocEvent, save_document_in_history
13-
from name.models import IesgDocStateName, DocStateName, DocInfoTagName
13+
from name.models import IesgDocStateName, DocStateName, DocTagName
1414
from person.models import Person, Email
1515

1616
INTERNET_DRAFT_DAYS_TO_EXPIRE = 185
@@ -349,7 +349,7 @@ def move_file_to(subdir):
349349
# revert version after having deleted tombstone
350350
doc.rev = "%02d" % (int(revision) - 1) # FIXME: messed up
351351
doc.save()
352-
doc.tags.add(DocInfoTagName.objects.get(slug='exp-tomb'))
352+
doc.tags.add(DocTagName.objects.get(slug='exp-tomb'))
353353
else:
354354
move_file_to("expired_without_tombstone")
355355

ietf/idrfc/mirror_rfc_editor_queue.py

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -196,14 +196,14 @@ def insert_into_database(drafts, refs):
196196
import django.db.transaction
197197

198198
def get_rfc_tag_mapping():
199-
"""Return dict with RFC Editor state name -> DocInfoTagName"""
200-
from name.models import DocInfoTagName
199+
"""Return dict with RFC Editor state name -> DocTagName"""
200+
from name.models import DocTagName
201201
from name.utils import name
202202

203203
return {
204-
'IANA': name(DocInfoTagName, 'iana-crd', 'IANA coordination', "RFC-Editor/IANA Registration Coordination"),
205-
'REF': name(DocInfoTagName, 'ref', 'Holding for references', "Holding for normative reference"),
206-
'MISSREF': name(DocInfoTagName, 'missref', 'Missing references', "Awaiting missing normative reference"),
204+
'IANA': name(DocTagName, 'iana-crd', 'IANA coordination', "RFC-Editor/IANA Registration Coordination"),
205+
'REF': name(DocTagName, 'ref', 'Holding for references', "Holding for normative reference"),
206+
'MISSREF': name(DocTagName, 'missref', 'Missing references', "Awaiting missing normative reference"),
207207
}
208208

209209
def get_rfc_state_mapping():
@@ -229,7 +229,7 @@ def get_rfc_state_mapping():
229229
@django.db.transaction.commit_on_success
230230
def insert_into_databaseREDESIGN(drafts, refs):
231231
from doc.models import Document
232-
from name.models import DocInfoTagName
232+
from name.models import DocTagName
233233

234234
tags = get_rfc_tag_mapping()
235235
states = get_rfc_state_mapping()

ietf/idrfc/mirror_rfc_index.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -168,7 +168,7 @@ def get_stream_mapping():
168168
return {
169169
"Legacy": name(DocStreamName, "legacy", "Legacy"),
170170
"IETF": name(DocStreamName, "ietf", "IETF"),
171-
"INDEPENDENT": name(DocStreamName, "ise", "Independent Submission"),
171+
"INDEPENDENT": name(DocStreamName, "ise", "ISE", desc="Independent submission editor stream"),
172172
"IAB": name(DocStreamName, "iab", "IAB"),
173173
"IRTF": name(DocStreamName, "irtf", "IRTF"),
174174
}
@@ -181,13 +181,13 @@ def insert_to_databaseREDESIGN(data):
181181
from person.models import Person
182182
from doc.models import Document, DocAlias, DocEvent, RelatedDocument
183183
from group.models import Group
184-
from name.models import DocInfoTagName, DocRelationshipName
184+
from name.models import DocTagName, DocRelationshipName
185185
from name.utils import name
186186

187187
system = Person.objects.get(name="(System)")
188188
std_level_mapping = get_std_level_mapping()
189189
stream_mapping = get_stream_mapping()
190-
tag_has_errata = name(DocInfoTagName, 'errata', "Has errata")
190+
tag_has_errata = name(DocTagName, 'errata', "Has errata")
191191
relationship_obsoletes = name(DocRelationshipName, "obs", "Obsoletes")
192192
relationship_updates = name(DocRelationshipName, "updates", "Updates")
193193

ietf/idrfc/views_edit.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@
2424
from ietf.idrfc.lastcall import request_last_call
2525

2626
from doc.models import Document, DocEvent, StatusDateDocEvent, TelechatDocEvent, save_document_in_history, DocHistory
27-
from name.models import IesgDocStateName, IntendedStdLevelName, DocInfoTagName, get_next_iesg_states, DocStateName
27+
from name.models import IesgDocStateName, IntendedStdLevelName, DocTagName, get_next_iesg_states, DocStateName
2828
from person.models import Person, Email
2929

3030
class ChangeStateForm(forms.Form):
@@ -548,7 +548,7 @@ def diff(attr, name):
548548
e.save()
549549

550550
if has_role(request.user, 'Secretariat'):
551-
via_rfc = DocInfoTagName.objects.get(slug="via-rfc")
551+
via_rfc = DocTagName.objects.get(slug="via-rfc")
552552
if r['via_rfc_editor']:
553553
doc.tags.add(via_rfc)
554554
else:

ietf/idrfc/views_search.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -308,7 +308,7 @@ def __init__(self, *args, **kwargs):
308308
inactive_ads.sort(key=extract_last_name)
309309

310310
self.fields['ad'].choices = c = [('', 'any AD')] + [(ad.pk, ad.name) for ad in active_ads] + [('', '------------------')] + [(ad.pk, ad.name) for ad in inactive_ads]
311-
self.fields['subState'].choices = [('', 'any substate'), ('0', 'no substate')] + [(n.slug, n.name) for n in DocInfoTagName.objects.filter(slug__in=('point', 'ad-f-up', 'need-rev', 'extpty'))]
311+
self.fields['subState'].choices = [('', 'any substate'), ('0', 'no substate')] + [(n.slug, n.name) for n in DocTagName.objects.filter(slug__in=('point', 'ad-f-up', 'need-rev', 'extpty'))]
312312
def clean_name(self):
313313
value = self.cleaned_data.get('name','')
314314
return normalize_draftname(value)

redesign/name/admin.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -12,14 +12,14 @@ class NameAdmin(admin.ModelAdmin):
1212
admin.site.register(DocStreamName, NameAdmin)
1313
admin.site.register(DocStateName, NameAdmin)
1414
admin.site.register(DocRelationshipName, NameAdmin)
15-
admin.site.register(WgDocStateName, NameAdmin)
1615
admin.site.register(IesgDocStateName, NameAdmin)
1716
admin.site.register(IanaDocStateName, NameAdmin)
1817
admin.site.register(RfcDocStateName, NameAdmin)
1918
admin.site.register(DocTypeName, NameAdmin)
20-
admin.site.register(DocInfoTagName, NameAdmin)
19+
admin.site.register(DocTagName, NameAdmin)
2120
admin.site.register(StdLevelName, NameAdmin)
2221
admin.site.register(IntendedStdLevelName, NameAdmin)
22+
admin.site.register(DocReminderTypeName, NameAdmin)
2323
admin.site.register(BallotPositionName, NameAdmin)
2424
admin.site.register(SessionStatusName, NameAdmin)
2525
admin.site.register(TimeSlotTypeName, NameAdmin)

0 commit comments

Comments
 (0)