Skip to content

Commit de2b6d4

Browse files
committed
Fix use of status still referring to the old attribute in the group
meeting page - Legacy-Id: 17142
1 parent 568670c commit de2b6d4

3 files changed

Lines changed: 9 additions & 11 deletions

File tree

ietf/doc/views_doc.py

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1349,10 +1349,6 @@ def all_presentations(request, name):
13491349
doc.session_set.filter(type__in=['regular','plenary','other'])
13501350
).filter(current_status__in=['sched','schedw','appr','canceled'])
13511351

1352-
status_names = {n.slug: n.name for n in SessionStatusName.objects.all()}
1353-
for session in sessions:
1354-
session.current_status_name = status_names.get(session.current_status, session.current_status)
1355-
13561352
future, in_progress, past = group_sessions(sessions)
13571353

13581354
return render(request, 'doc/material/all_presentations.html', {

ietf/meeting/utils.py

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,6 +19,7 @@
1919
from ietf.meeting.models import Session, Meeting, SchedulingEvent, TimeSlot
2020
from ietf.group.models import Group
2121
from ietf.group.utils import can_manage_materials
22+
from ietf.name.models import SessionStatusName
2223
from ietf.person.models import Email
2324
from ietf.secr.proceedings.proc_utils import import_audio_files
2425

@@ -51,9 +52,10 @@ def current_session_status(session):
5152

5253

5354
def group_sessions(sessions):
54-
55+
status_names = {n.slug: n.name for n in SessionStatusName.objects.all()}
5556
for s in sessions:
5657
s.time = session_time_for_sorting(s, use_meeting_date=True)
58+
s.current_status_name = status_names.get(s.current_status, s.current_status)
5759

5860
sessions = sorted(sessions,key=lambda s:s.time)
5961

ietf/templates/group/meetings-row.html

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -22,13 +22,13 @@
2222
{% endifchanged %}
2323
</td>
2424
<td class="text-right">
25-
{% if s.name %}{{ s.name }}<br>{% endif %}
26-
{% if s.status.slug == "sched" %}
27-
{{s.time|date:"D"}} &nbsp; {{s.time|date:"Y-m-d"}}
25+
{% if s.name %}{{ s.name }}<br>{% endif %}
26+
{% if s.current_status == "sched" %}
27+
{{s.time|date:"D"}} &nbsp; {{s.time|date:"Y-m-d"}}
2828
{% else %}
29-
{{s.status}}
29+
{{s.current_status_name}}
3030
{% endif %}
31-
{% if show_request and s.meeting.type.slug == 'ietf' %}
31+
{% if show_request and s.meeting.type_id == 'ietf' %}
3232
{% if can_edit %}
3333
<br>
3434
<a class="btn btn-default btn-xs" href="{% url 'ietf.secr.sreq.views.view' num=s.meeting.number acronym=s.group.acronym %}">Edit Session Request</a>
@@ -37,7 +37,7 @@
3737
</td>
3838
<td class="text-left padded-left ">
3939
{% if show_ical %}
40-
{% if s.meeting.type.slug == 'ietf' %}
40+
{% if s.meeting.type_id == 'ietf' %}
4141
{{s.time|date:"H:i"}}
4242
&nbsp;<a href="{% url 'ietf.meeting.views.ical_agenda' num=s.meeting.number session_id=s.id %}"><span class="fa fa-calendar"></span></a>
4343
{% else %}

0 commit comments

Comments
 (0)