Skip to content

Commit dd0a518

Browse files
committed
Added a comment warning about DocumentComment.created_by foreign key
- Legacy-Id: 1914
1 parent 6bf7fce commit dd0a518

1 file changed

Lines changed: 3 additions & 0 deletions

File tree

ietf/idtracker/models.py

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -661,6 +661,9 @@ class DocumentComment(models.Model):
661661
time = models.CharField(db_column='comment_time', max_length=20)
662662
version = models.CharField(blank=True, max_length=3)
663663
comment_text = models.TextField(blank=True)
664+
# NOTE: This is not a true foreign key -- it sometimes has values
665+
# (like 999) that do not exist in IESGLogin. So using select_related()
666+
# will break!
664667
created_by = models.ForeignKey(IESGLogin, db_column='created_by', null=True)
665668
result_state = models.ForeignKey(IDState, db_column='result_state', null=True, related_name="comments_leading_to_state")
666669
origin_state = models.ForeignKey(IDState, db_column='origin_state', null=True, related_name="comments_coming_from_state")

0 commit comments

Comments
 (0)