Skip to content

Commit d8cf039

Browse files
committed
Tweaked the use of the -p otpion of bin/mkrelease. Added sbirkholz@amsl.com to the release email addressees.
- Legacy-Id: 13222
1 parent b2db0d4 commit d8cf039

1 file changed

Lines changed: 19 additions & 17 deletions

File tree

bin/mkrelease

Lines changed: 19 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -178,22 +178,24 @@ changes=$( sed -n "/^$PROJ ($VER.*)/,/^ -- /p" changelog )
178178
[ "$changes" ] || die "No changelog information for $VER found"
179179
#note "$changes"
180180

181-
note "Checking that we don't have both schema and data migrations ..."
182-
cur=$(svn info | awk '/^Revision:/ { print $2 }')
183-
migrations=$(svn log $PWD -v -r HEAD:$((cur-100)) | sed -n -e '1,/^Set version info and settings back to development mode/p' | grep '^...A /.*/migrations/0.*.py' | cut -c6- | awk '{ print $1 }' | sed -re 's|/trunk/||')
184-
if [ -n "$migrations" -a -z "$PERMIT_MIGR_MIX" ]; then
185-
datamigr=$(for m in "$migrations"; do egrep -sl 'migrations\.RunPython' $m; done || true)
186-
schemamigr=$(for m in "$migrations"; do egrep -sl 'migrations\.(Add|Alter|Create|Delete|Remove|Rename)(Field|Model|UniqueTogether)' $m; done || true)
187-
if [ -n "$datamigr" -a -n "$schemamigr" ]; then
188-
echo -e "\n Schema migrations:"
189-
for m in $schemamigr; do
190-
echo " $m"
191-
done
192-
echo -e "\n Data migrations:"
193-
for m in $datamigr; do
194-
echo " $m"
195-
done
196-
die "\n Found both data migrations and schema migrations in this release.\n This is likely to cause delay between schema changes and deployment,\n which means the old code will run on the new schema longer than necessary."
181+
if [ -z "$PERMIT_MIGR_MIX" ]; then
182+
note "Checking that we don't have both schema and data migrations ..."
183+
cur=$(svn info | awk '/^Revision:/ { print $2 }')
184+
migrations=$(svn log $PWD -v -r HEAD:$((cur-100)) | sed -n -e '1,/^Set version info and settings back to development mode/p' | grep '^...A /.*/migrations/0.*.py' | cut -c6- | awk '{ print $1 }' | sed -re 's|/trunk/||')
185+
if [ -n "$migrations" ]; then
186+
datamigr=$(for m in "$migrations"; do egrep -sl 'migrations\.RunPython' $m; done || true)
187+
schemamigr=$(for m in "$migrations"; do egrep -sl 'migrations\.(Add|Alter|Create|Delete|Remove|Rename)(Field|Model|UniqueTogether)' $m; done || true)
188+
if [ -n "$datamigr" -a -n "$schemamigr" ]; then
189+
echo -e "\n Schema migrations:"
190+
for m in $schemamigr; do
191+
echo " $m"
192+
done
193+
echo -e "\n Data migrations:"
194+
for m in $datamigr; do
195+
echo " $m"
196+
done
197+
die "\n Found both data migrations and schema migrations in this release.\n This is likely to cause delay between schema changes and deployment,\n which means the old code will run on the new schema longer than necessary."
198+
fi
197199
fi
198200
fi
199201

@@ -313,7 +315,7 @@ Regards,
313315
(via the mkrelease script)
314316
" > ~/src/db/mail/release-mail-v$VER.txt
315317

316-
cat ~/src/db/mail/release-mail-v$VER.txt | $do mail -s "New datatracker release: v$VER" housley@vigilsec.com rjs@nostrum.com henrik@levkowetz.com -c glen@amsl.com -c fenner@fenron.net -c cmorgan@amsl.com -c avezza@amsl.com -c amorris@amsl.com -c smccammon@amsl.com -c kmoreland@amsl.com -c olau@iola.dk -c mlarson@amsl.com $contributors
318+
cat ~/src/db/mail/release-mail-v$VER.txt | $do mail -s "New datatracker release: v$VER" housley@vigilsec.com rjs@nostrum.com henrik@levkowetz.com -c glen@amsl.com -c fenner@fenron.net -c cmorgan@amsl.com -c avezza@amsl.com -c amorris@amsl.com -c smccammon@amsl.com -c kmoreland@amsl.com -c olau@iola.dk -c mlarson@amsl.com -c sbirkholz@amsl.com $contributors
317319

318320
cat ~/src/db/mail/release-mail-v$VER.txt | $do mail -s "New datatracker release: v$VER" iesg@ietf.org wgchairs@ietf.org codesprints@ietf.org -b henrik@levkowetz.com
319321

0 commit comments

Comments
 (0)