Add an expertise field to reviewer settings. Fixes ietf-tools#2308. Commit ready for merge,

 - Legacy-Id: 13532

Author: rjsparks

ietf/group/tests_review.py

@@ -374,14 +374,16 @@ def test_change_reviewer_settings(self):
             "action": "change_settings",
             "min_interval": "7",
             "filter_re": "test-[regexp]",
-            "remind_days_before_deadline": "6"
+            "remind_days_before_deadline": "6",
+            "expertise": "Some expertise",
         })
         self.assertEqual(r.status_code, 302)
         settings = ReviewerSettings.objects.get(person=reviewer, team=review_req.team)
         self.assertEqual(settings.min_interval, 7)
         self.assertEqual(settings.filter_re, "test-[regexp]")
         self.assertEqual(settings.skip_next, 0)
         self.assertEqual(settings.remind_days_before_deadline, 6)
+        self.assertEqual(settings.expertise, "Some expertise")
         self.assertEqual(len(outbox), 1)
         self.assertTrue("reviewer availability" in outbox[0]["subject"].lower())
         msg_content = outbox[0].get_payload(decode=True).decode("utf-8").lower()

ietf/group/views_review.py

@@ -446,7 +446,7 @@ def email_open_review_assignments(request, acronym, group_type=None):
 class ReviewerSettingsForm(forms.ModelForm):
     class Meta:
         model = ReviewerSettings
-        fields = ['min_interval', 'filter_re', 'skip_next', 'remind_days_before_deadline']
+        fields = ['min_interval', 'filter_re', 'skip_next', 'remind_days_before_deadline','expertise']
 
     def __init__(self, *args, **kwargs):
        exclude_fields = kwargs.pop('exclude_fields', [])

ietf/review/models.py

@@ -25,6 +25,7 @@ class ReviewerSettings(models.Model):
         help_text="Draft names matching this regular expression should not be assigned")
     skip_next   = models.IntegerField(default=0, verbose_name="Skip next assignments")
     remind_days_before_deadline = models.IntegerField(null=True, blank=True, help_text="To get an email reminder in case you forget to do an assigned review, enter the number of days before review deadline you want to receive it. Clear the field if you don't want a reminder.")
+    expertise = models.TextField(verbose_name="Reviewer's expertise in this team's area", max_length=2048, blank=True, help_text="Describe the reviewer's expertise in this team's area", default='')
 
     def __unicode__(self):
         return u"{} in {}".format(self.person, self.team)

ietf/templates/group/reviewer_overview.html

@@ -39,7 +39,7 @@ <h2>Reviewers</h2>
               {% elif person.busy %}class="busy"
               {% elif person.settings.skip_next %}class="skip-next"
               {% endif %}>
-            <td>{% if person.settings_url %}<a href="{{ person.settings_url }}">{% endif %}{{ person }}{% if person.settings_url %}</a>{% endif %}</td>
+            <td>{% if person.settings_url %}<a href="{{ person.settings_url }}" title="{{person.settings.expertise}}">{% endif %}{{ person }}{% if person.settings_url %}</a>{% endif %}</td>
             <td>
               <table class="simple-table">
                 {% for req_pk, doc_name, reviewed_rev, assigned_time, deadline, state, assignment_to_closure_days in person.latest_reqs %}