Skip to content

Commit d7b4709

Browse files
committed
* Added alternating colours for the entry rows in the form tables
* Fixed yes/no radio button layout * Fixed submitter contact information copying for generic form - Legacy-Id: 143
1 parent f9c6c5c commit d7b4709

6 files changed

Lines changed: 208 additions & 132 deletions

File tree

ietf/ipr/urls.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
(r'^ipr-(?P<ipr_id>\d+)/$', views.show),
88
(r'^update/$', views.updatelist),
99
(r'^update/(?P<ipr_id>\d+)/$', views.update),
10-
(r'^new-(?P<type>(specific|generic|third_party))/$', views.new),
10+
(r'^new-(?P<type>(specific|generic|third-party))/$', views.new),
1111
)
1212

1313
queryset = models.IprDetail.objects.all()

ietf/ipr/view_new.py

Lines changed: 16 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -89,6 +89,7 @@ class IprForm(BaseIprForm):
8989
rfclist = forms.CharField(required=False)
9090
draftlist = forms.CharField(required=False)
9191
stdonly_license = forms.BooleanField(required=False)
92+
hold_contact_is_submitter = forms.BooleanField(required=False)
9293
ietf_contact_is_submitter = forms.BooleanField(required=False)
9394
if "holder_contact" in section_list:
9495
holder_contact = ContactForm(prefix="hold")
@@ -102,27 +103,31 @@ def __init__(self, *args, **kw):
102103
self.base_fields[contact] = ContactForm(prefix=contact[:4], *args, **kw)
103104
self.base_fields["rfclist"] = forms.CharField(required=False)
104105
self.base_fields["draftlist"] = forms.CharField(required=False)
105-
self.base_fields["ietf_contact_is_submitter"] = forms.BooleanField(required=False)
106+
if "holder_contact" in section_list:
107+
self.base_fields["hold_contact_is_submitter"] = forms.BooleanField(required=False)
108+
if "ietf_contact" in section_list:
109+
self.base_fields["ietf_contact_is_submitter"] = forms.BooleanField(required=False)
110+
self.base_fields["stdonly_license"] = forms.BooleanField(required=False)
111+
106112
BaseIprForm.__init__(self, *args, **kw)
107113
# Special validation code
108114
def clean(self):
109115
# Required:
110116
# Submitter form filled in or 'same-as-ietf-contact' marked
111117
# Only one of rfc, draft, and other info fields filled in
112118
# RFC exists or draft exists and has right rev. or ...
113-
114-
if self.ietf_contact_is_submitter:
115-
self.submitter = self.ietf_contact
116119
pass
120+
117121
if request.method == 'POST':
118122
data = request.POST.copy()
119-
if "ietf_contact_is_submitter" in data:
120-
for subfield in ["name", "title", "department", "address1", "address2", "telephone", "fax", "email"]:
121-
try:
122-
data["subm_%s"%subfield] = data["ietf_%s"%subfield]
123-
except Exception, e:
124-
#log("Caught exception: %s"%e)
125-
pass
123+
for src in ["hold", "ietf"]:
124+
if "%s_contact_is_submitter" % src in data:
125+
for subfield in ["name", "title", "department", "address1", "address2", "telephone", "fax", "email"]:
126+
try:
127+
data[ "subm_%s" % subfield ] = data[ "%s_%s" % (src,subfield) ]
128+
except Exception, e:
129+
#log("Caught exception: %s"%e)
130+
pass
126131
form = IprForm(data)
127132
if form.ietf_contact_is_submitter:
128133
form.ietf_contact_is_submitter_checked = "checked"

ietf/ipr/view_sections.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@
1717
"disclosure_type": "Generic", "form_legend": False,
1818
"per_rfc_disclosure": False, "also_specific": True,
1919
},
20-
"third_party": {"index": False, "title": True, "third_party": True,
20+
"third-party": {"index": False, "title": True, "third_party": True,
2121
"legacy_intro": False, "new_intro": True, "form_intro": False,
2222
"holder": True, "holder_contact": False, "ietf_contact": True,
2323
"ietf_doc": True, "patent_info": True, "licensing": False,

0 commit comments

Comments
 (0)