Use tempfiles while rebuilding group and doc alias files. Fixes ietf-tools#3521. Commit ready for merge.

 - Legacy-Id: 19949

Author: rjsparks

ietf/doc/management/commands/generate_draft_aliases.py

@@ -9,6 +9,8 @@
 import os
 import re
 import time
+
+from tempfile import mkstemp
 
 from django.conf import settings
 from django.core.management.base import BaseCommand
@@ -102,8 +104,13 @@ def handle(self, *args, **options):
         date = time.strftime("%Y-%m-%d_%H:%M:%S")
         signature = '# Generated by %s at %s\n' % (os.path.abspath(__file__), date)
 
-        afile = io.open(settings.DRAFT_ALIASES_PATH, "w")
-        vfile = io.open(settings.DRAFT_VIRTUAL_PATH, "w")
+        ahandle, aname = mkstemp()
+        os.close(ahandle)
+        afile = io.open(aname,"w")
+
+        vhandle, vname = mkstemp()
+        os.close(vhandle)
+        vfile = io.open(vname,"w")
 
         afile.write(signature)
         vfile.write(signature)
@@ -160,4 +167,8 @@ def handle(self, *args, **options):
 
         afile.close()
         vfile.close()
+
+        os.rename(aname, settings.DRAFT_ALIASES_PATH)
+        os.rename(vname, settings.DRAFT_VIRTUAL_PATH)
+
 

ietf/group/management/commands/generate_group_aliases.py

@@ -8,6 +8,8 @@
 import io
 import os
 import time
+
+from tempfile import mkstemp
 
 from django.conf import settings
 from django.core.management.base import BaseCommand
@@ -40,8 +42,13 @@ def handle(self, *args, **options):
         date = time.strftime("%Y-%m-%d_%H:%M:%S")
         signature = '# Generated by %s at %s\n' % (os.path.abspath(__file__), date)
 
-        afile = io.open(settings.GROUP_ALIASES_PATH, "w")
-        vfile = io.open(settings.GROUP_VIRTUAL_PATH, "w")
+        ahandle, aname = mkstemp()
+        os.close(ahandle)
+        afile = io.open(aname,"w")
+
+        vhandle, vname = mkstemp()
+        os.close(vhandle)
+        vfile = io.open(vname,"w")
 
         afile.write(signature)
         vfile.write(signature)
@@ -86,4 +93,7 @@ def handle(self, *args, **options):
             dump_sublist(afile, vfile, group.acronym+'-chairs', IETF_DOMAIN, settings.GROUP_VIRTUAL_DOMAIN, get_group_role_emails(group, ['chair', 'delegate']))
 
         afile.close()
-        vfile.close()
+        vfile.close()
+
+        os.rename(aname, settings.GROUP_ALIASES_PATH)
+        os.rename(vname, settings.GROUP_VIRTUAL_PATH)