Skip to content

Commit ceff544

Browse files
committed
Update the feedback count badge when new feedback is provided. Fixes ietf-tools#2260. Commit ready for merge.
- Legacy-Id: 13388
1 parent cf382d3 commit ceff544

2 files changed

Lines changed: 5 additions & 0 deletions

File tree

ietf/nomcom/tests.py

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -857,6 +857,8 @@ def feedback_view(self, *args, **kwargs):
857857
self.assertEqual(response.status_code, 200)
858858
self.assertContains(response, "alert-success")
859859
self.assertNotContains(response, "feedbackform")
860+
q = PyQuery(response.content)
861+
self.assertEqual( int(q("#nominees .badge").text()), Feedback.objects.filter(positions__in=[position],nominees__in=[nominee],type_id='comment').count() )
860862

861863
## check objects
862864
feedback = Feedback.objects.filter(positions__in=[position],

ietf/nomcom/views.py

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -452,6 +452,9 @@ def feedback(request, year, public):
452452
form.save()
453453
messages.success(request, 'Your feedback has been registered.')
454454
form = None
455+
counts.setdefault(position.pk,dict())
456+
counts[position.pk].setdefault(nominee.pk,0)
457+
counts[position.pk][nominee.pk] += 1
455458
else:
456459
if nominee and position:
457460
form = FeedbackForm(nomcom=nomcom, user=request.user, public=public,

0 commit comments

Comments
 (0)