Skip to content

Commit cbda267

Browse files
committed
Removed some unreachable code.
- Legacy-Id: 14150
1 parent 0e00adc commit cbda267

4 files changed

Lines changed: 2 additions & 112 deletions

File tree

ietf/doc/utils.py

Lines changed: 0 additions & 23 deletions
Original file line numberDiff line numberDiff line change
@@ -195,29 +195,6 @@ def close_open_ballots(doc, by):
195195
for t in BallotType.objects.filter(doc_type=doc.type_id):
196196
close_ballot(doc, by, t.slug )
197197

198-
def augment_with_start_time(docs):
199-
"""Add a started_time attribute to each document with the time of
200-
the first revision."""
201-
from ietf.utils import log
202-
log.unreachable("2017-07-08")
203-
docs = list(docs)
204-
205-
docs_dict = {}
206-
for d in docs:
207-
docs_dict[d.pk] = d
208-
d.start_time = None
209-
210-
seen = set()
211-
212-
for e in DocEvent.objects.filter(type="new_revision", doc__in=docs).order_by('time'):
213-
if e.doc_id in seen:
214-
continue
215-
216-
docs_dict[e.doc_id].start_time = e.time
217-
seen.add(e.doc_id)
218-
219-
return docs
220-
221198
def get_chartering_type(doc):
222199
chartering = ""
223200
if doc.get_state_slug() not in ("notrev", "approved"):

ietf/group/models.py

Lines changed: 0 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -281,18 +281,6 @@ class Role(models.Model):
281281
def __unicode__(self):
282282
return u"%s is %s in %s" % (self.person.plain_name(), self.name.name, self.group.acronym or self.group.name)
283283

284-
def name_and_email(self):
285-
"""
286-
Returns name and email, e.g.: u'Ano Nymous <ano@nymous.org>'
287-
Is intended for display use, not in email context.
288-
Use self.formatted_email() for that.
289-
"""
290-
log.unreachable("2017-06-06")
291-
if self.person:
292-
return u"%s <%s>" % (self.person.plain_name(), self.email.address)
293-
else:
294-
return u"<%s>" % self.address
295-
296284
def formatted_ascii_email(self):
297285
return email.utils.formataddr((self.person.plain_ascii(), self.email.address))
298286

ietf/meeting/views.py

Lines changed: 2 additions & 52 deletions
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@
1010
import csv
1111
import json
1212
import pytz
13-
from pyquery import PyQuery
13+
1414
from wsgiref.handlers import format_date_time
1515
from calendar import timegm
1616

@@ -47,7 +47,7 @@
4747
from ietf.meeting.helpers import get_modified_from_assignments
4848
from ietf.meeting.helpers import get_wg_list, find_ads_for_meeting
4949
from ietf.meeting.helpers import get_meeting, get_schedule, agenda_permissions, get_ietf_meeting
50-
from ietf.meeting.helpers import preprocess_assignments_for_agenda, read_agenda_file, read_session_file
50+
from ietf.meeting.helpers import preprocess_assignments_for_agenda, read_agenda_file
5151
from ietf.meeting.helpers import convert_draft_to_pdf, get_earliest_session_date
5252
from ietf.meeting.helpers import can_view_interim_request, can_approve_interim_request
5353
from ietf.meeting.helpers import can_edit_interim_request
@@ -60,7 +60,6 @@
6060
from ietf.secr.proceedings.utils import handle_upload_file
6161
from ietf.secr.proceedings.proc_utils import (get_progress_stats, post_process, import_audio_files,
6262
import_youtube_video_urls)
63-
from ietf.utils import log
6463
from ietf.utils.mail import send_mail_message
6564
from ietf.utils.pipe import pipe
6665
from ietf.utils.pdf import pdf_pages
@@ -623,55 +622,6 @@ def agenda_by_type_ics(request,num=None,type=None):
623622
updated = meeting.updated()
624623
return render(request,"meeting/agenda.ics",{"schedule":schedule,"updated":updated,"assignments":assignments},content_type="text/calendar")
625624

626-
def session_document(request, num, acronym, type="agenda"):
627-
log.unreachable("2017-07-22")
628-
d = Document.objects.filter(type=type, session__meeting__number=num)
629-
if acronym == "plenaryt":
630-
d = d.filter(session__name__icontains="technical", session__slots__type="plenary")
631-
elif acronym == "plenaryw":
632-
d = d.filter(session__name__icontains="admin", session__slots__type="plenary")
633-
else:
634-
d = d.filter(session__group__acronym=acronym)
635-
636-
if d:
637-
doc = d[0]
638-
html5_preamble = "<!doctype html><html lang=en><head><meta charset=utf-8><title>%s</title></head><body>"
639-
html5_postamble = "</body></html>"
640-
content, path = read_session_file(type, num, doc)
641-
_, ext = os.path.splitext(path)
642-
ext = ext.lstrip(".").lower()
643-
644-
if not content:
645-
content = "Could not read %s file '%s'" % (type, path)
646-
return HttpResponse(content, content_type="text/plain; charset=%s"%settings.DEFAULT_CHARSET)
647-
648-
if ext == "txt":
649-
return HttpResponse(content, content_type="text/plain; charset=%s"%settings.DEFAULT_CHARSET)
650-
elif ext == "pdf":
651-
return HttpResponse(content, content_type="application/pdf")
652-
elif ext in ["html", "htm"]:
653-
content=re.sub("(\r\n|\r)", "\n", content)
654-
d = PyQuery(content)
655-
d("head title").empty()
656-
d("head title").append(str(doc))
657-
d('meta[http-equiv]').remove()
658-
content = "<!doctype html>" + str(d)
659-
else:
660-
content = "<p>Unrecognized %s file '%s'</p>" % (type, doc.external_url)
661-
content = (html5_preamble % doc) + content + html5_postamble
662-
663-
return HttpResponse(content)
664-
665-
raise Http404("No %s for the %s session of IETF %s is available" % (type, acronym, num))
666-
667-
def session_agenda(request, num, session):
668-
log.unreachable("2017-07-22")
669-
return session_document(request, num, acronym=session, type='agenda')
670-
671-
def session_minutes(request, num, session):
672-
log.unreachable("2017-07-22")
673-
return session_document(request, num, acronym=session, type='minutes')
674-
675625
def session_draft_list(num, session):
676626
try:
677627
agendas = Document.objects.filter(type="agenda",

ietf/secr/meetings/views.py

Lines changed: 0 additions & 25 deletions
Original file line numberDiff line numberDiff line change
@@ -233,31 +233,6 @@ def send_notifications(meeting, groups, person):
233233
GroupEvent.objects.create(group=group,time=now,type='sent_notification',
234234
by=person,desc='sent scheduled notification for %s' % meeting)
235235

236-
def sort_groups(meeting,schedule=None):
237-
'''
238-
Similar to sreq.views.sort_groups
239-
Takes a Meeting object and returns a tuple scheduled_groups, unscheduled groups.
240-
'''
241-
from ietf.utils import log
242-
log.unreachable("2017-07-08")
243-
if not schedule:
244-
schedule = meeting.agenda
245-
scheduled_groups = []
246-
unscheduled_groups = []
247-
#sessions = Session.objects.filter(meeting=meeting,status__in=('schedw','apprw','appr','sched','notmeet','canceled'))
248-
sessions = Session.objects.filter(meeting=meeting,status__in=('schedw','apprw','appr','sched','canceled'))
249-
groups_with_sessions = [ s.group for s in sessions ]
250-
gset = set(groups_with_sessions)
251-
sorted_groups_with_sessions = sorted(gset, key = lambda instance: instance.acronym)
252-
scheduled_sessions = SchedTimeSessAssignment.objects.filter(schedule=schedule,session__isnull=False)
253-
groups_with_timeslots = [ x.session.group for x in scheduled_sessions ]
254-
for group in sorted_groups_with_sessions:
255-
if group in groups_with_timeslots:
256-
scheduled_groups.append(group)
257-
else:
258-
unscheduled_groups.append(group)
259-
260-
return scheduled_groups, unscheduled_groups
261236

262237
# -------------------------------------------------
263238
# AJAX Functions

0 commit comments

Comments
 (0)