Fixed an issue where a session was saved without a type_id, found by the Django 2.2 checks. The code set the value just after the first save, and then did a second save, but this is 1) more costly, and 2) keeps an invalid session object in the database for a short time.

 - Legacy-Id: 18084

Author: levkowetz

ietf/meeting/forms.py

@@ -250,9 +250,11 @@ def clean_requested_duration(self):
     def save(self, *args, **kwargs):
         """NOTE: as the baseform of an inlineformset self.save(commit=True)
         never gets called"""
-        session = super(InterimSessionModelForm, self).save(commit=kwargs.get('commit', True))
+        session = super(InterimSessionModelForm, self).save(commit=False)
         session.group = self.group
         session.type_id = 'regular'
+        if kwargs.get('commit', True) is True:
+            super(InterimSessionModelForm, self).save(commit=True)
         return session
 
     def save_agenda(self):