Skip to content

Commit caa3ec9

Browse files
committed
Changed the menu listing of review dirs and their display on the Directorates page back to what it was before the 'reviews' group type was split out. Added a 'Reviews' column to the Directoratges page.
- Legacy-Id: 15420
1 parent 0c732d6 commit caa3ec9

3 files changed

Lines changed: 8 additions & 2 deletions

File tree

ietf/doc/templatetags/active_groups_menu.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77

88
@register.simple_tag
99
def active_groups_menu():
10-
parents = GroupTypeName.objects.filter(slug__in=['ag','area','team','dir','review','program'])
10+
parents = GroupTypeName.objects.filter(slug__in=['ag','area','team','dir','program'])
1111
for p in parents:
1212
p.menu_url = '/%s/'%p.slug
1313
return render_to_string('base/menu_active_groups.html', { 'parents': parents })

ietf/group/views.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -305,7 +305,7 @@ def active_group_types(request):
305305
return render(request, 'group/active_groups.html', {'grouptypes':grouptypes})
306306

307307
def active_dirs(request):
308-
dirs = Group.objects.filter(type="dir", state="active").order_by("name")
308+
dirs = Group.objects.filter(type__in=['dir', 'review'], state="active").order_by("name")
309309
for group in dirs:
310310
group.chairs = sorted(roles(group, "chair"), key=extract_last_name)
311311
group.ads = sorted(roles(group, "ad"), key=extract_last_name)

ietf/templates/group/active_dirs.html

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -17,6 +17,7 @@ <h1>Active Directorates</h1>
1717
<tr>
1818
<th>Team</th>
1919
<th>Name</th>
20+
<th>Reviews</th>
2021
<th>Area</th>
2122
<th>AD</th>
2223
<th>Secretaries</th>
@@ -28,6 +29,11 @@ <h1>Active Directorates</h1>
2829
<tr>
2930
<td><a href="{% url "ietf.group.views.group_home" acronym=group.acronym %}">{{ group.acronym }}</a></td>
3031
<td>{{ group.name }}</td>
32+
<td class="text-center">
33+
{% if group.type_id == 'review' %}
34+
<span class="fa fa-check tiny"><span class="hidden">yes</span></span>
35+
{% endif %}
36+
</td>
3137
<td><a href="{% url "ietf.group.views.group_home" acronym=group.parent.acronym %}">{{ group.parent.acronym }}</a></td>
3238
<td>
3339
{% for ad in group.ads %}

0 commit comments

Comments
 (0)