Skip to content

Commit c9e99e3

Browse files
committed
Refined the code in ietf.sync.rfceditor that deals with errata to distinguish between rejected errata and other errata.
- Legacy-Id: 18279
1 parent 83a74c8 commit c9e99e3

1 file changed

Lines changed: 8 additions & 3 deletions

File tree

ietf/sync/rfceditor.py

Lines changed: 8 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -497,18 +497,23 @@ def parse_relation_list(l):
497497
DocAlias.objects.create(name=a).docs.add(doc)
498498
changes.append("created alias %s" % prettify_std_name(a))
499499

500-
if has_errata:
500+
doc_errata = errata.get('RFC%04d'%rfc_number, [])
501+
all_rejected = doc_errata and all( er['errata_status_code']=='Rejected' for er in doc_errata )
502+
if has_errata and not all_rejected:
501503
if not doc.tags.filter(pk=tag_has_errata.pk).exists():
502504
doc.tags.add(tag_has_errata)
503505
changes.append("added Errata tag")
504-
has_verified_errata = name.upper() in errata and any([ er['errata_status_code']=='Verified' for er in errata[name.upper()] ])
506+
has_verified_errata = any([ er['errata_status_code']=='Verified' for er in doc_errata ])
505507
if has_verified_errata and not doc.tags.filter(pk=tag_has_verified_errata.pk).exists():
506508
doc.tags.add(tag_has_verified_errata)
507509
changes.append("added Verified Errata tag")
508510
else:
509511
if doc.tags.filter(pk=tag_has_errata.pk):
510512
doc.tags.remove(tag_has_errata)
511-
changes.append("removed Errata tag")
513+
if all_rejected:
514+
changes.append("removed Errata tag (all errata rejected)")
515+
else:
516+
changes.append("removed Errata tag")
512517
if doc.tags.filter(pk=tag_has_verified_errata.pk):
513518
doc.tags.remove(tag_has_verified_errata)
514519
changes.append("removed Verified Errata tag")

0 commit comments

Comments
 (0)