Skip to content

Commit c9756cc

Browse files
committed
Merged in [19153] from rjsparks@nostrum.com:
Scroll to buttons before clicking on them in Selenium tests. Fixes ietf-tools#3314. - Legacy-Id: 19154 Note: SVN reference [19153] has been migrated to Git commit d61e265
2 parents 01cd13b + d61e265 commit c9756cc

2 files changed

Lines changed: 9 additions & 0 deletions

File tree

ietf/group/tests_js.py

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -45,6 +45,7 @@ def _click_milestone_submit_button(self, label):
4545
expected_conditions.element_to_be_clickable((By.CSS_SELECTOR, submit_button_selector))
4646
)
4747
self.assertIn(label, submit_button.text)
48+
self.scroll_to_element(submit_button)
4849
submit_button.click()
4950

5051
def _assert_milestone_changed(self):
@@ -80,6 +81,7 @@ def test_add_milestone(self):
8081
expected_conditions.element_to_be_clickable(
8182
(By.CSS_SELECTOR, 'button.add-milestone')
8283
))
84+
self.scroll_to_element(add_milestone_button)
8385
add_milestone_button.click()
8486

8587
edit_div = self.wait.until(

ietf/meeting/tests_js.py

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -921,6 +921,7 @@ def test_agenda_view_group_filter_toggle(self):
921921

922922
# Click the group button
923923
group_button = self.get_agenda_filter_group_button(wait, group_acronym)
924+
self.scroll_to_element(group_button)
924925
group_button.click()
925926

926927
# Check visibility
@@ -986,6 +987,7 @@ def _schedule_session(meeting, session):
986987

987988
# enable hackathon group
988989
group_button = self.get_agenda_filter_group_button(wait, 'hackathon')
990+
self.scroll_to_element(group_button)
989991
group_button.click()
990992
self.assert_agenda_item_visibility(['mars', 'hackathon'])
991993

@@ -1027,6 +1029,7 @@ def test_agenda_view_group_filter_toggle_without_replace_state(self):
10271029

10281030
# Be sure we're at the URL we think we're at before we click
10291031
self.assertEqual(self.driver.current_url, url)
1032+
self.scroll_to_element(group_button)
10301033
group_button.click() # click!
10311034

10321035
expected_url = '%s?show=%s' % (url, group_acronym)
@@ -1136,6 +1139,7 @@ def test_session_materials_modal(self):
11361139
),
11371140
'Modal open button not found or not clickable',
11381141
)
1142+
self.scroll_to_element(open_modal_button)
11391143
open_modal_button.click()
11401144
WebDriverWait(self.driver, 2).until(
11411145
expected_conditions.visibility_of(modal_div),
@@ -1168,6 +1172,7 @@ def test_session_materials_modal(self):
11681172
),
11691173
'Modal close button not found or not clickable',
11701174
)
1175+
self.scroll_to_element(close_modal_button)
11711176
close_modal_button.click()
11721177
WebDriverWait(self.driver, 2).until(
11731178
expected_conditions.invisibility_of_element(modal_div),
@@ -1187,6 +1192,7 @@ def test_session_materials_modal(self):
11871192
),
11881193
'Modal open button not found or not clickable for refresh test',
11891194
)
1195+
self.scroll_to_element(open_modal_button)
11901196
open_modal_button.click()
11911197
WebDriverWait(self.driver, 2).until(
11921198
expected_conditions.visibility_of(modal_div),
@@ -1644,6 +1650,7 @@ def advance_month():
16441650
button = WebDriverWait(self.driver, 2).until(
16451651
expected_conditions.element_to_be_clickable(
16461652
(By.CSS_SELECTOR, 'div#calendar button.fc-next-button')))
1653+
self.scroll_to_element(button)
16471654
button.click()
16481655

16491656
seen = set()

0 commit comments

Comments
 (0)