Skip to content

Commit c915c5f

Browse files
committed
* Added automatic 'required-field' indicator to the form rendering
* Made 'Legal Name' field in the IprDetails model required - Legacy-Id: 107
1 parent 26a9783 commit c915c5f

4 files changed

Lines changed: 5 additions & 4 deletions

File tree

ietf/ipr/models.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -77,7 +77,7 @@ class Admin:
7777

7878
class IprDetail(models.Model):
7979
ipr_id = models.AutoField(primary_key=True)
80-
p_h_legal_name = models.CharField("Legal Name", blank=True, maxlength=255)
80+
p_h_legal_name = models.CharField("Legal Name", maxlength=255)
8181
document_title = models.CharField(blank=True, maxlength=255)
8282
rfc_number = models.IntegerField(null=True, editable=False, blank=True) # always NULL
8383
id_document_tag = models.IntegerField(null=True, editable=False, blank=True) # always NULL

ietf/templates/ipr/formfield.html

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,4 +5,5 @@
55
{% endfor %}
66
</ul>
77
{% endif %}
8-
{{ field }}{{ help_text }}
8+
{% if field.required %}<span class="required">*</span>{% endif %}{{ text }}
9+
{{ help_text }}

ietf/templates/ipr/style.html

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,6 +22,6 @@
2222
input[type="checkbox"] { width: auto; }
2323
input[type="submit"] { width: auto; }
2424
textarea { width: 72ex; height: 5em; font-family: sans-serif; font-size: 11pt; font-weight: normal; }
25-
.required { color: red; }
25+
.required { color: red; float: right; padding-top: 1ex; }
2626
.errorlist { background: red; padding: 0 0 0 2px; border: 0px; margin: 0px; }
2727
</style>

ietf/utils.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -266,6 +266,6 @@ def __getitem__(self, name):
266266
return field
267267
bf = forms.forms.BoundField(self, field, name)
268268
errors = [escape(error) for error in bf.errors]
269-
rendering = loader.render_to_string(self._template, { "errors": errors, "label": bf.label, "field": unicode(bf), "help_text": field.help_text })
269+
rendering = loader.render_to_string(self._template, { "errors": errors, "label": bf.label, "text": unicode(bf), "help_text": field.help_text, "field":field })
270270
return rendering
271271
return FormattingForm

0 commit comments

Comments
 (0)