Skip to content

Commit c8a99dc

Browse files
committed
Allow secretariat to edit session requests when tool is closed to chairs. Fixes ietf-tools#3547. Commit ready for merge.
- Legacy-Id: 19919
1 parent 336ed54 commit c8a99dc

2 files changed

Lines changed: 7 additions & 1 deletion

File tree

ietf/secr/sreq/tests.py

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -733,6 +733,12 @@ def test_edit_request(self):
733733
r = self.client.get(url)
734734
self.assertEqual(r.status_code, 200)
735735
q = PyQuery(r.content)
736+
self.assertEqual(len(q(':disabled[name="submit"]')), 0)
737+
chair = self.group.role_set.filter(name_id='chair').first().person.user.username
738+
self.client.login(username=chair, password=f'{chair}+password')
739+
r = self.client.get(url)
740+
self.assertEqual(r.status_code, 200)
741+
q = PyQuery(r.content)
736742
self.assertEqual(len(q(':disabled[name="submit"]')), 1)
737743

738744
def test_view_request(self):

ietf/secr/sreq/views.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -572,7 +572,7 @@ def edit(request, acronym, num=None):
572572
form = FormClass(group, meeting, initial=initial)
573573

574574
return render(request, 'sreq/edit.html', {
575-
'is_locked': is_locked,
575+
'is_locked': is_locked and not has_role(request.user,'Secretariat'),
576576
'is_virtual': meeting.number in settings.SECR_VIRTUAL_MEETINGS,
577577
'meeting': meeting,
578578
'form': form,

0 commit comments

Comments
 (0)