Skip to content

Commit c474b42

Browse files
committed
Send review reminders output to log, rather than stdout (since this is run from cron, stdout and stderr should be quiet if nothing unexpected happens)
- Legacy-Id: 16878
1 parent e2cc982 commit c474b42

1 file changed

Lines changed: 9 additions & 4 deletions

File tree

ietf/bin/send-review-reminders

Lines changed: 9 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -26,6 +26,7 @@ from ietf.review.utils import (
2626
review_assignments_needing_secretary_reminder, email_secretary_reminder,
2727
send_unavaibility_period_ending_reminder, send_reminder_all_open_reviews,
2828
send_review_reminder_overdue_assignment, send_reminder_unconfirmed_assignments)
29+
from ietf.utils.log import log
2930

3031
today = datetime.date.today()
3132

@@ -39,13 +40,17 @@ for assignment, secretary_role in review_assignments_needing_secretary_reminder(
3940
print("Emailed reminder to {} for review of {} in {} (req. id {})".format(secretary_role.email.address, review_req.doc_id, review_req.team.acronym, review_req.pk))
4041

4142
period_end_reminders_sent = send_unavaibility_period_ending_reminder(today)
42-
print('\n'.join(period_end_reminders_sent))
43+
for msg in period_end_reminders_sent:
44+
log(msg)
4345

4446
overdue_reviews_reminders_sent = send_review_reminder_overdue_assignment(today)
45-
print('\n'.join(overdue_reviews_reminders_sent))
47+
for msg in overdue_reviews_reminders_sent:
48+
log(msg)
4649

4750
open_reviews_reminders_sent = send_reminder_all_open_reviews(today)
48-
print('\n'.join(open_reviews_reminders_sent))
51+
for msg in open_reviews_reminders_sent:
52+
log(msg)
4953

5054
unconfirmed_assignment_reminders_sent = send_reminder_unconfirmed_assignments(today)
51-
print('\n'.join(unconfirmed_assignment_reminders_sent))
55+
for msg in unconfirmed_assignment_reminders_sent:
56+
log(msag)

0 commit comments

Comments
 (0)