Revamp the layout in the manage review requests page. Drop the table

OleLaursen · OleLaursen · commit c3e8cabafb2c · 2016-11-07T21:20:15.000Z
and instead provide more information about each document to be
reviewed, to help the secretaries determine locally on that page what
action to take. The new layout should also make it easier to fit in
more info, in case it is still found lacking.

The public review request page still provides the previous information
in the summarized tabular form, so the overview can be found there.
 - Legacy-Id: 12278
diff --git a/ietf/group/views_review.py b/ietf/group/views_review.py
@@ -35,7 +35,7 @@ def get_open_review_requests_for_team(team, assignment_status=None):
         team=team,
         state__in=("requested", "accepted")
     ).prefetch_related(
-        "reviewer__person", "type", "state"
+        "reviewer__person", "type", "state", "doc", "doc__states",
     ).order_by("-time", "-id")
 
     if assignment_status == "unassigned":
@@ -234,6 +234,8 @@ def manage_review_requests(request, acronym, group_type=None, assignment_status=
     query_dict = request.POST.copy() if request.method == "POST" else None
 
     for req in review_requests:
+        req.form = ManageReviewRequestForm(req, query_dict)
+
         # add previous requests
         l = []
         for r in document_requests.get(req.doc_id, []):
@@ -249,8 +251,6 @@ def manage_review_requests(request, acronym, group_type=None, assignment_status=
 
         req.latest_reqs = l
 
-        req.form = ManageReviewRequestForm(req, query_dict)
-
     saving = False
     newly_closed = newly_opened = newly_assigned = 0
 
diff --git a/ietf/review/utils.py b/ietf/review/utils.py
@@ -550,13 +550,14 @@ def suggested_review_requests_for_team(team):
 
         telechat_docs = reviewable_docs_qs.filter(
             docevent__telechatdocevent__telechat_date__in=telechat_dates
-        ).values_list("pk", flat=True)
+        )
 
         # we need to check the latest telechat event for each document
         # scheduled for the telechat, as the appearance might have been
         # cancelled/moved
         telechat_events = TelechatDocEvent.objects.filter(
-            doc__in=list(telechat_docs), # explicitly turn into list so we don't get a complex and slow join sent down to the DB
+            # turn into list so we don't get a complex and slow join sent down to the DB
+            doc__in=list(telechat_docs.values_list("pk", flat=True)),
         ).values_list(
             "doc", "pk", "time", "telechat_date"
         ).order_by("doc", "-time", "-id").distinct()
diff --git a/ietf/static/ietf/css/ietf.css b/ietf/static/ietf/css/ietf.css
@@ -503,16 +503,19 @@ form.complete-review .mail-archive-search-result .date {
 
 form.review-requests .reviewer-controls, form.review-requests .close-controls {
   display: none;
-  padding-right: 1em;
 }
 
 form.review-requests .assign-action, form.review-requests .close-action {
   display: inline-block;
-  min-width: 11em;
+  margin-left: 0.5em;
+}
+
+form.review-requests .request-metadata {
+  margin-bottom: 0.5em;
 }
 
-form.review-requests .deadline {
-  padding-top: 0.45em;
+form.review-requests .abstract {
+  font-size: 95%;
 }
 
 form.review-requests label {
diff --git a/ietf/static/ietf/js/manage-review-requests.js b/ietf/static/ietf/js/manage-review-requests.js
@@ -27,7 +27,7 @@ $(document).ready(function () {
     }
 
     form.find(".assign-action button").on("click", function () {
-        var row = $(this).closest("tr");
+        var row = $(this).closest(".review-request");
 
         var select = row.find(".reviewer-controls [name$=\"-reviewer\"]");
         if (!select.val()) {
@@ -39,7 +39,7 @@ $(document).ready(function () {
             });
 
             form.find("[name$=\"-action\"][value=\"assign\"]").each(function () {
-                var v = $(this).closest("tr").find("[name$=\"-reviewer\"]").val();
+                var v = $(this).closest(".review-request").find("[name$=\"-reviewer\"]").val();
                 if (v)
                     reviewerAssigned[v] += 1;
             });
@@ -70,20 +70,20 @@ $(document).ready(function () {
     });
 
     form.find(".reviewer-controls .undo").on("click", function () {
-        var row = $(this).closest("tr");
+        var row = $(this).closest(".review-request");
         row.find("[name$=\"-action\"]").val("");
         row.find("[name$=\"-reviewer\"]").val($(this).data("initial"));
         setControlDisplay(row);
     });
 
     form.find(".close-action button").on("click", function () {
-        var row = $(this).closest("tr");
+        var row = $(this).closest(".review-request");
         row.find("[name$=\"-action\"]").val("close");
         setControlDisplay(row);
     });
 
     form.find(".close-controls .undo").on("click", function () {
-        var row = $(this).closest("tr");
+        var row = $(this).closest(".review-request");
         row.find("[name$=\"-action\"]").val("");
         setControlDisplay(row);
     });
@@ -93,7 +93,7 @@ $(document).ready(function () {
         if (!v)
             return;
 
-        var row = $(this).closest("tr");
+        var row = $(this).closest(".review-request");
         setControlDisplay(row);
     });
 
diff --git a/ietf/templates/group/manage_review_requests.html b/ietf/templates/group/manage_review_requests.html
@@ -38,104 +38,115 @@ <h1>Manage {{ assignment_status }} open review requests for {{ group.acronym }}<
 
   {% if review_requests %}
     <form class="review-requests" method="post">{% csrf_token %}
-      <table class="table table-condensed table-striped materials">
-        <thead>
-          <tr>
-            <th>Document</th>
-            <th>Deadline</th>
-            <th style="min-width:65%">Action</th>
-          </tr>
-        </thead>
-        <tbody>
-          {% for r in review_requests %}
-            <tr>
-              <td>
-                <a href="{% if r.requested_rev %}{% url "doc_view" name=r.doc.name rev=r.requested_rev %}{% else %}{% url "doc_view" name=r.doc.name %}{% endif %}">{{ r.doc.name }}-{% if r.requested_rev %}{{ r.requested_rev }}{% else %}{{ r.doc.rev }}{% endif %}</a>
 
-                <div>
-                  <small>
-                    {% if r.pk != None %}<a href="{% url "ietf.doc.views_review.review_request" name=r.doc.name request_id=r.pk %}">Req: {{ r.time|date:"Y-m-d" }}{% else %}<em>auto-suggested</em>{% endif %} - {{ r.type.name }}{% if r.pk != None %}</a>{% endif %}
-                  </small>
-                </div>
-
-                {% if r.latest_reqs %}
-                  {% for rlatest in r.latest_reqs %}
-                    <div>
-                      <small>- prev. review of {% if rlatest.doc_id != r.doc_id %}{{ rlatest.doc_id }}{% endif %}-{{ rlatest.reviewed_rev }}:
-                        <a href="{% url "ietf.doc.views_review.review_request" name=rlatest.doc_id request_id=rlatest.pk %}">{% if rlatest.result %}{{ rlatest.result.name }}{% else %}result unavail.{% endif %}</a>
-                        (<a href="{{ rfcdiff_base_url }}?url1={{ rlatest.doc.name }}-{{ rlatest.reviewed_rev }}&url2={{ r.doc.name }}-{{ r.doc.rev }}">diff</a>){% if not forloop.last %},{% endif %}
-                      </small>
-                    </div>
-                  {% endfor %}
-                {% endif %}
+      {% for r in review_requests %}
+        <div class="panel panel-default review-request">
+          <div class="panel-heading">
 
-                {% if r.form.non_field_errors %}
-                  <div class="alert alert-danger">
-                    {% for e in r.form.non_field_errors %}
-                      {{ e }}
-                    {% endfor %}
-                  </div>
-                {% endif %}
-              </td>
-              <td class="deadline">
-                {{ r.deadline|date:"Y-m-d" }}
+            <h3 class="panel-title">
+              <span class="pull-right">
+                {{ r.type.name }}
+                - deadline: {{ r.deadline|date:"Y-m-d" }}
                 {% if r.due %}<span class="label label-warning">{{ r.due }} day{{ r.due|pluralize }}</span>{% endif %}
-              </td>
-              <td>
-                <input type="hidden" name="reviewrequest" value="{{ r.pk }}">
-                <input type="hidden" name="{{ r.form.prefix }}-existing_reviewer" value="{{ r.reviewer_id|default:"" }}">
-
-                <span class="assign-action">
-                  {% if r.reviewer %}
-                    <button type="button" class="btn btn-default btn-sm" title="Click to reassign reviewer">
-                      {{ r.reviewer.person }}
-                      {% if r.state_id == "accepted" %} <span class="label label-default">accp</span>{% endif %}
-                      {% if r.reviewer_unavailable %}<span class="label label-danger">unavail</span>{% endif %}
-                    </button>
-                  {% else %}
-                    <button type="button" class="btn btn-default btn-sm" title="Click to assign reviewer"><em>not yet assigned</em></button>
-                  {% endif %}
-                </span>
-
-                {{ r.form.action }}
-
-                <span class="reviewer-controls form-inline">
-                  <label for="{{ r.form.reviewer.id_for_label }}">Assign:</label>
-                  {{ r.form.reviewer }}
-                  <button type="button" class="btn btn-default btn-sm undo" title="Cancel assignment" data-initial="{{ r.form.fields.reviewer.initial|default:"" }}">Cancel</button>
-                  {% if r.form.reviewer.errors %}
-                    <div class="alert alert-danger">
-                      {% for e in r.form.reviewer.errors %}
-                        {{ e }}
-                      {% endfor %}
-                    </div>
+              </span>
+
+              <a href="{% if r.requested_rev %}{% url "doc_view" name=r.doc.name rev=r.requested_rev %}{% else %}{% url "doc_view" name=r.doc.name %}{% endif %}?include_text=1">{{ r.doc.name }}-{% if r.requested_rev %}{{ r.requested_rev }}{% else %}{{ r.doc.rev }}{% endif %}</a>
+            </h3>
+          </div>
+
+          <div class="panel-body">
+            <div class="row">
+              <div class="col-sm-6">
+                <div class="request-metadata">
+                  {% if r.pk != None %}Requested: <a href="{% url "ietf.doc.views_review.review_request" name=r.doc.name request_id=r.pk %}">{{ r.time|date:"Y-m-d" }}</a>{% else %}Auto-suggested{% endif %}
+
+                  {% if r.latest_reqs %}
+                    {% for rlatest in r.latest_reqs %}
+                      - previous review of <a href="{% url "doc_view" name=rlatest.doc_id rev=rlatest.reviewed_rev %}?include_text=1">{% if rlatest.doc_id != r.doc_id %}{{ rlatest.doc_id }}{% endif %}-{{ rlatest.reviewed_rev }}</a>:
+                      <a href="{% url "ietf.doc.views_review.review_request" name=rlatest.doc_id request_id=rlatest.pk %}">{% if rlatest.result %}{{ rlatest.result.name }}{% else %}result unavail.{% endif %}</a>
+                      (<a href="{{ rfcdiff_base_url }}?url1={{ rlatest.doc.name }}-{{ rlatest.reviewed_rev }}&url2={{ r.doc.name }}-{{ r.doc.rev }}">diff</a>){% if not forloop.last %},{% endif %}
+                    {% endfor %}
                   {% endif %}
-                </span>
-
-                <span class="close-action">
-                  <button type="button" class="btn btn-default btn-sm">Close...</button>
-                </span>
-
-                <span class="close-controls form-inline">
-                  <label for="{{ r.form.reviewer.id_for_label }}">Close:</label>
-                  {{ r.form.close }}
-                  <button type="button" class="btn btn-default btn-sm undo" title="Cancel closing">Cancel</button>
-                  {% if r.form.close.errors %}
-                    <br>
-                    {{ r.form.close.errors }}
+                </div>
+
+                <div><strong>{{ r.doc.title }}</strong></div>
+
+                <div>
+                  {{ r.doc.pages }} page{{ r.doc.pages|pluralize }}
+                  - {{ r.doc.friendly_state }}
+                  {% if r.doc.group.type_id != "individ" %}
+                    - <a href="{% url "ietf.group.views.group_home" acronym=r.doc.group.acronym group_type=r.doc.group.type_id %}">{{ r.doc.group.acronym }} {{ r.doc.group.type.name }}</a>
                   {% endif %}
-                </span>
-              </td>
-            </tr>
-          {% endfor %}
-        </tbody>
-      </table>
+                </div>
+              </div>
+
+              <div class="col-sm-6 abstract">
+                {{ r.doc.abstract|linebreaks }}
+              </div>
+            </div>
+          </div>
+          
+          <div class="panel-footer">
+            {% if r.form.non_field_errors %}
+              <div class="alert alert-danger">
+                {% for e in r.form.non_field_errors %}
+                  {{ e }}
+                {% endfor %}
+              </div>
+            {% endif %}
+
+            <input type="hidden" name="reviewrequest" value="{{ r.pk }}">
+            <input type="hidden" name="{{ r.form.prefix }}-existing_reviewer" value="{{ r.reviewer_id|default:"" }}">
+
+            <span class="assign-action">
+              {% if r.reviewer %}
+                <button type="button" class="btn btn-default" title="Click to reassign reviewer">
+                  {{ r.reviewer.person }}
+                  {% if r.state_id == "accepted" %} <span class="label label-default">accp</span>{% endif %}
+                  {% if r.reviewer_unavailable %}<span class="label label-danger">unavail</span>{% endif %}
+                </button>
+              {% else %}
+                <button type="button" class="btn btn-default" title="Click to assign reviewer"><em>Not yet assigned</em></button>
+              {% endif %}
+            </span>
+
+            {{ r.form.action }}
+
+            <span class="reviewer-controls form-inline">
+              <label for="{{ r.form.reviewer.id_for_label }}">Assign:</label>
+              {{ r.form.reviewer }}
+              <button type="button" class="btn btn-default undo" title="Cancel assignment" data-initial="{{ r.form.fields.reviewer.initial|default:"" }}">Cancel</button>
+              {% if r.form.reviewer.errors %}
+                <div class="alert alert-danger">
+                  {% for e in r.form.reviewer.errors %}
+                    {{ e }}
+                  {% endfor %}
+                </div>
+              {% endif %}
+            </span>
+
+            <span class="close-action">
+              <button type="button" class="btn btn-default">Close...</button>
+            </span>
+
+            <span class="close-controls form-inline">
+              <label for="{{ r.form.reviewer.id_for_label }}">Close:</label>
+              {{ r.form.close }}
+              <button type="button" class="btn btn-default undo" title="Cancel closing">Cancel</button>
+              {% if r.form.close.errors %}
+                <br>
+                {{ r.form.close.errors }}
+              {% endif %}
+            </span>
+          </div>
+        </div>
+      {% endfor %}
 
       {% buttons %}
       <a href="{% url "ietf.group.views_review.review_requests" group_type=group.type_id acronym=group.acronym %}" class="btn btn-default pull-right">Cancel</a>
-        <button class="btn btn-primary" type="submit" name="action" value="save">Save changes</button>
-        <button class="btn btn-primary" type="submit" name="action" value="save-continue">Save and continue editing</button>
-        <button class="btn btn-default" type="submit" name="action" value="refresh">Refresh (keeping changes)</button>
+      <button class="btn btn-primary" type="submit" name="action" value="save">Save changes</button>
+      <button class="btn btn-primary" type="submit" name="action" value="save-continue">Save and continue editing</button>
+      <button class="btn btn-default" type="submit" name="action" value="refresh">Refresh (keeping changes)</button>
       {% endbuttons %}
     </form>
   {% else %}
