Skip to content

Commit c3ad0b5

Browse files
committed
Catch exception which is raised if a nomcom NN group has been created, but no nomcom chair has been announced and added yet.
- Legacy-Id: 4385
1 parent 9f3cf38 commit c3ad0b5

1 file changed

Lines changed: 13 additions & 8 deletions

File tree

ietf/announcements/views.py

Lines changed: 13 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,7 @@
44
from django.shortcuts import get_object_or_404
55
from django.conf import settings
66
from django.db.models import Q
7+
from django.core.exceptions import ObjectDoesNotExist
78

89
import re
910

@@ -51,14 +52,18 @@ def nomcomREDESIGN(request):
5152
e = GroupEvent.objects.filter(group=n, type="changed_state", changestategroupevent__state="conclude").order_by('time')[:1]
5253
n.end_year = e[0].time.year if e else ""
5354

54-
chair = n.role_set.select_related().get(name="chair")
55-
announcements = Message.objects.filter(related_groups=n).order_by('-time')
56-
for a in announcements:
57-
a.to_name = address_re.sub("", a.to)
58-
59-
regimes.append(dict(chair=chair,
60-
announcements=announcements,
61-
group=n))
55+
# A nomcom chair may not exist even if the nomcom NN group has been created:
56+
try:
57+
chair = n.role_set.select_related().get(name="chair")
58+
announcements = Message.objects.filter(related_groups=n).order_by('-time')
59+
for a in announcements:
60+
a.to_name = address_re.sub("", a.to)
61+
62+
regimes.append(dict(chair=chair,
63+
announcements=announcements,
64+
group=n))
65+
except ObjectDoesNotExist:
66+
pass
6267

6368
regimes.sort(key=lambda x: x["group"].start_year, reverse=True)
6469

0 commit comments

Comments
 (0)