Skip to content

Commit c305498

Browse files
committed
Prevent issues for logins without Person records by not letting Person-less users through login.
- Legacy-Id: 15528
1 parent 7dccae2 commit c305498

1 file changed

Lines changed: 6 additions & 1 deletion

File tree

ietf/ietfauth/views.py

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -41,7 +41,7 @@
4141
from django import forms
4242
from django.contrib import messages
4343
from django.conf import settings
44-
from django.contrib.auth import update_session_auth_hash
44+
from django.contrib.auth import update_session_auth_hash, logout
4545
from django.contrib.auth.decorators import login_required
4646
from django.contrib.auth.forms import AuthenticationForm
4747
from django.contrib.auth.hashers import identify_hasher
@@ -604,6 +604,11 @@ def login(request, extra_context=None):
604604
}
605605
response = LoginView.as_view(extra_context=extra_context)(request)
606606
if isinstance(response, HttpResponseRedirect) and user.is_authenticated:
607+
try:
608+
user.person
609+
except Person.DoesNotExist:
610+
logout(request)
611+
response = render(request, 'registration/missing_person.html')
607612
if require_consent:
608613
messages.warning(request, mark_safe("""
609614

0 commit comments

Comments
 (0)