Skip to content

Commit c1d75da

Browse files
committed
Merged [7748] from rjsparks@nostrum.com: Adjust when publication request button appears for documents in non-ietf streams. Fixes bug ietf-tools#1402.
- Legacy-Id: 7765 Note: SVN reference [7748] has been migrated to Git commit e9984b9
2 parents 58cc1f3 + e9984b9 commit c1d75da

2 files changed

Lines changed: 19 additions & 1 deletion

File tree

ietf/doc/tests.py

Lines changed: 16 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -351,6 +351,22 @@ def test_state_help(self):
351351
self.assertEqual(r.status_code, 200)
352352
self.assertTrue(State.objects.get(type="draft-iesg", slug="lc").name in r.content)
353353

354+
def test_document_nonietf_pubreq_button(self):
355+
doc = make_test_data()
356+
357+
self.client.login(username='iab-chair', password='iab-chair+password')
358+
r = self.client.get(urlreverse("doc_view", kwargs=dict(name=doc.name)))
359+
self.assertEqual(r.status_code, 200)
360+
q = PyQuery(r.content)
361+
self.assertFalse(q('.actions'))
362+
363+
Document.objects.filter(pk=doc.pk).update(stream='iab')
364+
r = self.client.get(urlreverse("doc_view", kwargs=dict(name=doc.name)))
365+
self.assertEqual(r.status_code, 200)
366+
q = PyQuery(r.content)
367+
self.assertTrue('IESG state' in q('.actions').html())
368+
369+
354370
class AddCommentTestCase(TestCase):
355371
def test_add_comment(self):
356372
draft = make_test_data()

ietf/doc/views_doc.py

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -311,10 +311,12 @@ def document_main(request, name, rev=None):
311311
actions.append((label, urlreverse('conflict_review_start', kwargs=dict(name=doc.name))))
312312

313313
if (doc.get_state_slug() != "expired" and doc.stream_id in ("iab", "ise", "irtf")
314-
and can_edit_stream_info and not iesg_state):
314+
and can_edit_stream_info):
315315
label = "Request Publication"
316316
if not doc.intended_std_level:
317317
label += " (note that intended status is not set)"
318+
if iesg_state and iesg_state.slug != 'dead':
319+
label += " (Warning: the IESG state indicates ongoing IESG processing)"
318320
actions.append((label, urlreverse('doc_request_publication', kwargs=dict(name=doc.name))))
319321

320322
if doc.get_state_slug() != "expired" and doc.stream_id in ("ietf",):

0 commit comments

Comments
 (0)