Skip to content

Commit c19268f

Browse files
committed
A second pass of pyflakes cleanup, removing additional bulk imports, fixing a bug in get_initial_notify(), and removing some dead (and buggy) code.
- Legacy-Id: 7509
1 parent 87a944f commit c19268f

20 files changed

Lines changed: 74 additions & 68 deletions

ietf/community/migrations/0002_add_display_config.py

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,4 @@
1-
21
from south.db import db
3-
from django.db import models # pyflakes:ignore
4-
from ietf.community.models import * # pyflakes:ignore
52

63
class Migration:
74

ietf/community/migrations/0003_add_notifications.py

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,4 @@
1-
21
from south.db import db
3-
from django.db import models # pyflakes:ignore
4-
from ietf.community.models import * # pyflakes:ignore
52

63
class Migration:
74

ietf/community/migrations/0004_refactor_notifications_with_docevent.py

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,4 @@
1-
21
from south.db import db
3-
from django.db import models # pyflakes:ignore
4-
from ietf.community.models import * # pyflakes:ignore
52

63
class Migration:
74

ietf/community/migrations/0005_auto__add_field_communitylist_secret.py

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,4 @@
1-
21
from south.db import db
3-
from django.db import models # pyflakes:ignore
4-
from ietf.community.models import * # pyflakes:ignore
52

63
class Migration:
74

ietf/community/migrations/0006_auto__add_field_communitylist_cached.py

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,4 @@
1-
21
from south.db import db
3-
from django.db import models # pyflakes:ignore
4-
from ietf.community.models import * # pyflakes:ignore
52

63
class Migration:
74

ietf/community/migrations/0007_auto__add_unique_rule_community_list_rule_type_value.py

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,5 @@
1-
# encoding: utf-8
2-
import datetime # pyflakes:ignore
31
from south.db import db
42
from south.v2 import SchemaMigration
5-
from django.db import models # pyflakes:ignore
63

74
class Migration(SchemaMigration):
85

ietf/doc/models.py

Lines changed: 6 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,18 +1,21 @@
11
# Copyright The IETF Trust 2007, All Rights Reserved
22

3+
import datetime, os
4+
35
from django.db import models
46
from django.core.urlresolvers import reverse as urlreverse
57
from django.contrib.contenttypes.models import ContentType
68
from django.conf import settings
79
from django.utils.html import mark_safe
810

11+
import debug # pyflakes:ignore
12+
913
from ietf.group.models import Group
10-
from ietf.name.models import * # pyflakes:ignore
14+
from ietf.name.models import ( DocTypeName, DocTagName, StreamName, IntendedStdLevelName, StdLevelName,
15+
DocRelationshipName, DocReminderTypeName, BallotPositionName )
1116
from ietf.person.models import Email, Person
1217
from ietf.utils.admin import admin_link
1318

14-
import datetime, os
15-
import debug # pyflakes:ignore
1619

1720
class StateType(models.Model):
1821
slug = models.CharField(primary_key=True, max_length=30) # draft, draft-iesg, charter, ...
@@ -164,8 +167,6 @@ class RelatedDocument(models.Model):
164167
relationship = models.ForeignKey(DocRelationshipName)
165168
def action(self):
166169
return self.relationship.name
167-
def inverse_action():
168-
return self.relationship.revname
169170
def __unicode__(self):
170171
return u"%s %s %s" % (self.source.name, self.relationship.name.lower(), self.target.name)
171172

ietf/doc/tests.py

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -8,12 +8,13 @@
88

99
from django.core.urlresolvers import reverse as urlreverse
1010

11-
from ietf.doc.models import * # pyflakes:ignore
12-
from ietf.name.models import * # pyflakes:ignore
13-
11+
from ietf.doc.models import ( Document, DocAlias, DocRelationshipName, RelatedDocument, State,
12+
DocEvent, BallotPositionDocEvent, LastCallDocEvent, WriteupDocEvent )
13+
from ietf.group.models import Group
14+
from ietf.person.models import Person
1415
from ietf.utils.mail import outbox
15-
from ietf.utils.test_utils import login_testing_unauthorized
1616
from ietf.utils.test_data import make_test_data
17+
from ietf.utils.test_utils import login_testing_unauthorized
1718
from ietf.utils.test_utils import TestCase
1819

1920
class SearchTestCase(TestCase):

ietf/doc/tests_ballot.py

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,12 @@
11
import datetime
22
from pyquery import PyQuery
3+
34
import debug # pyflakes:ignore
45

56
from django.core.urlresolvers import reverse as urlreverse
67

7-
from ietf.doc.models import * # pyflakes:ignore
8-
8+
from ietf.doc.models import ( Document, State, DocEvent, BallotDocEvent,
9+
BallotPositionDocEvent, LastCallDocEvent, WriteupDocEvent )
910
from ietf.group.models import Group, Role
1011
from ietf.name.models import BallotPositionName
1112
from ietf.person.models import Person

ietf/doc/tests_charter.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7,8 +7,8 @@
77
from django.conf import settings
88
from django.core.urlresolvers import reverse as urlreverse
99

10-
from ietf.doc.models import * # pyflakes:ignore
11-
10+
from ietf.doc.models import ( Document, State, BallotDocEvent, BallotType, NewRevisionDocEvent,
11+
TelechatDocEvent, WriteupDocEvent )
1212
from ietf.doc.utils_charter import next_revision, default_review_text, default_action_text
1313
from ietf.group.models import Group, GroupMilestone
1414
from ietf.iesg.models import TelechatDate

0 commit comments

Comments
 (0)