Skip to content

Commit bf38ef3

Browse files
committed
Improve to manage pending feedback errors.
See ietf-tools#975 - Legacy-Id: 5585
1 parent 1715197 commit bf38ef3

2 files changed

Lines changed: 5 additions & 4 deletions

File tree

ietf/nomcom/views.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -400,8 +400,8 @@ def view_feedback_pending(request, year):
400400
exclude=('nomcom', 'comments'),
401401
extra=0)
402402
feedbacks = Feedback.objects.filter(Q(type__isnull=True) |
403-
Q(nominee__isnull=True) |
404-
Q(positions__isnull=True))
403+
Q(nominee__isnull=True) |
404+
Q(positions__isnull=True))
405405
if request.method == 'POST':
406406
formset = FeedbackFormSet(request.POST)
407407
if formset.is_valid():

ietf/templates/nomcom/view_feedback_pending.html

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -19,11 +19,12 @@ <h2>Feedback pending from email list</h2>
1919
<form id="feedbackformset" action="" method="post">{% csrf_token %}
2020
{{ formset.management_form }}
2121
{% for form in formset.forms %}
22-
<h3 class="ietf-divider">{{ form.instance.time|date:"Y-m-d" }}</h3>
22+
<h3 class="ietf-divider">{{ form.instance.time|date:"Y-m-d" }} id:{{ form.instance.id }}</h3>
23+
{% if form.errors %}<div class="info-message-error">Please correct the following errors</div>{% endif %}
2324
<div>
2425
{% for field in form %}
2526
<div>
26-
{% if not field.field.widget.is_hidden %}{{ field.label_tag }}:{% endif %} {{ field }}
27+
{% if not field.field.widget.is_hidden %}{{ field.label_tag }}:{% endif %} {{ field }}{{ field.errors }}
2728
</div>
2829
{% endfor %}
2930
{% decrypt form.instance.comments request year %}

0 commit comments

Comments
 (0)