Skip to content

Commit bbd9d3f

Browse files
committed
Fix comparison (between int and bool) so changes in agenda status is reported correctly
- Legacy-Id: 2500
1 parent fa7af53 commit bbd9d3f

2 files changed

Lines changed: 3 additions & 2 deletions

File tree

branch/iesg-tracker/ietf/idrfc/tests.py

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -270,8 +270,9 @@ def test_add_draft(self):
270270
self.assertEquals(draft.idinternal.job_owner, job_owner)
271271
self.assertEquals(draft.idinternal.note, "This is a note")
272272
self.assertTrue(not draft.idinternal.agenda)
273-
self.assertEquals(draft.idinternal.comments().count(), 3)
273+
self.assertEquals(draft.idinternal.comments().count(), 2)
274274
self.assertTrue("Draft added" in draft.idinternal.comments()[0].comment_text)
275+
self.assertTrue("This is a note" in draft.idinternal.comments()[1].comment_text)
275276
self.assertEquals(len(mail_outbox), mailbox_before)
276277

277278

branch/iesg-tracker/ietf/idrfc/utils.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -79,7 +79,7 @@ def update_telechat(request, idinternal, new_telechat_date, new_returning_item=N
7979

8080
# update agenda
8181
doc = idinternal.document()
82-
if idinternal.agenda != on_agenda:
82+
if bool(idinternal.agenda) != on_agenda:
8383
if on_agenda:
8484
add_document_comment(request, doc,
8585
"Placed on agenda for telechat - %s" % new_telechat_date)

0 commit comments

Comments
 (0)