Skip to content

Commit b98c7ec

Browse files
author
nick
committed
feat: add nomcom questionnaires tabs tests
Commit ready for merge. - Legacy-Id: 19698
1 parent 8ab1408 commit b98c7ec

4 files changed

Lines changed: 34 additions & 15 deletions

File tree

.devcontainer/devcontainer.json

Lines changed: 13 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -58,18 +58,19 @@
5858

5959
// Add the IDs of extensions you want installed when the container is created.
6060
"extensions": [
61-
"ms-python.python",
62-
"ms-python.vscode-pylance",
63-
"ms-azuretools.vscode-docker",
64-
"editorconfig.editorconfig",
65-
"redhat.vscode-yaml",
66-
"visualstudioexptteam.vscodeintellicode",
67-
"batisteo.vscode-django",
68-
"mutantdino.resourcemonitor",
69-
"spmeesseman.vscode-taskexplorer",
70-
"mtxr.sqltools",
71-
"mtxr.sqltools-driver-mysql"
72-
],
61+
"ms-python.python",
62+
"ms-python.vscode-pylance",
63+
"ms-azuretools.vscode-docker",
64+
"editorconfig.editorconfig",
65+
"redhat.vscode-yaml",
66+
"visualstudioexptteam.vscodeintellicode",
67+
"batisteo.vscode-django",
68+
"mutantdino.resourcemonitor",
69+
"spmeesseman.vscode-taskexplorer",
70+
"mtxr.sqltools",
71+
"mtxr.sqltools-driver-mysql",
72+
"mrmlnc.vscode-duplicate"
73+
],
7374

7475
// Use 'forwardPorts' to make a list of ports inside the container available locally.
7576
"forwardPorts": [8000, 3306],

cypress/integration/meeting/nomcom.spec.js renamed to cypress/integration/nomcom/expertise.spec.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
/// <reference types="cypress" />
22

3-
describe('nomcom', () => {
3+
describe('expertise', () => {
44
before(() => {
55
cy.visit('/nomcom/2021/expertise/')
66
})
Lines changed: 18 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,18 @@
1+
/// <reference types="cypress" />
2+
3+
describe('questionnaires', () => {
4+
before(() => {
5+
cy.visit('/nomcom/2021/questionnaires/')
6+
})
7+
8+
it('position tabs should display the appropriate panel on click', () => {
9+
cy.get('.nomcom-questnr-positions-tabs > li > a').each($tab => {
10+
cy.wrap($tab).click()
11+
cy.wrap($tab).parent().should('have.class', 'active')
12+
13+
cy.wrap($tab).invoke('attr', 'href').then($tabId => {
14+
cy.get($tabId).should('have.class', 'tab-pane').and('have.class', 'active').and('be.visible')
15+
})
16+
})
17+
})
18+
})

ietf/templates/nomcom/questionnaires.html

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -8,15 +8,15 @@
88
{% origin %}
99
<h2>Questionnaires</h2>
1010

11-
<ul class="nav nav-tabs" role="tablist">
11+
<ul class="nomcom-questnr-positions-tabs nav nav-tabs" role="tablist">
1212
{% for position in positions %}
1313
<li {% if forloop.first %}class="active"{% endif %}>
1414
<a data-toggle="tab" role="tab" href="#{{ position.name|slugify }}">{{ position.name }}</a>
1515
</li>
1616
{% endfor %}
1717
</ul>
1818

19-
<div class="tab-content">
19+
<div class="nomcom-questnr-positions-content tab-content">
2020
{% for position in positions %}
2121
<div class="tab-pane {% if forloop.first %}active{% endif %}" id="{{ position.name|slugify }}">
2222
{{ position.get_questionnaire|linebreaks}}

0 commit comments

Comments
 (0)