Skip to content

Commit b8ca530

Browse files
committed
/ipr/: remove separate list for updating
- Legacy-Id: 2120
1 parent 58a6dc0 commit b8ca530

6 files changed

Lines changed: 9 additions & 88 deletions

File tree

ietf/ipr/testurl.list

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@
2020
200 /ipr/new-specific/?_testpost=1
2121
200 /ipr/new-third-party/?_testpost=1
2222

23-
200 /ipr/update/
23+
301 /ipr/update/
2424
200 /ipr/update/657/ # Generic
2525
200 /ipr/update/820/ # Third-party
2626
200 /ipr/update/844/ # Specific

ietf/ipr/urls.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,14 +2,14 @@
22

33
from django.conf.urls.defaults import patterns
44
from ietf.ipr import views, new, search
5+
from django.views.generic.simple import redirect_to
56

67
urlpatterns = patterns('',
78
(r'^$', views.showlist),
89
(r'^about/$', views.default),
910
(r'^by-draft/$', views.list_drafts),
10-
#(r'^(?P<removed>removed/)?(?P<ipr_id>\d+)/$', views.show),
1111
(r'^(?P<ipr_id>\d+)/$', views.show),
12-
(r'^update/$', views.updatelist),
12+
(r'^update/$', redirect_to, { 'url': '/ipr/' }),
1313
(r'^update/(?P<ipr_id>\d+)/$', new.update),
1414
(r'^new-(?P<type>specific)/$', new.new),
1515
(r'^new-(?P<type>generic)/$', new.new),

ietf/ipr/views.py

Lines changed: 1 addition & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -11,27 +11,17 @@
1111
from ietf.utils import log
1212
import os
1313

14-
1514
def default(request):
1615
"""Default page, with links to sub-pages"""
1716
return render("ipr/disclosure.html", {}, context_instance=RequestContext(request))
1817

1918
def showlist(request):
20-
"""Display a list of existing disclosures"""
21-
return list_all(request, 'ipr/list.html')
22-
23-
def updatelist(request):
24-
"""Display a list of existing disclosures, with links to update forms"""
25-
return list_all(request, 'ipr/update_list.html')
26-
27-
def list_all(request, template):
28-
"""Display a list of existing disclosures, using the provided template"""
2919
disclosures = IprDetail.objects.all()
3020
generic_disclosures = disclosures.filter(status__in=[1,3], generic=1)
3121
specific_disclosures = disclosures.filter(status__in=[1,3], generic=0, third_party=0)
3222
thirdpty_disclosures = disclosures.filter(status__in=[1,3], generic=0, third_party=1)
3323

34-
return render(template,
24+
return render("ipr/list.html",
3525
{
3626
'generic_disclosures' : generic_disclosures.order_by(* ['-submitted_date', ] ),
3727
'specific_disclosures': specific_disclosures.order_by(* ['-submitted_date', ] ),

ietf/templates/ipr/details.html

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -84,7 +84,10 @@ <h1>{{ ipr.title|escape }}</h1>
8484
{% endifequal %}
8585
{% endfor %}
8686

87-
<p>Click <a href="{% url ietf.ipr.new.update ipr.ipr_id %}" rel="nofollow">here</a> to update this IPR disclosure</p>
87+
<p><a href="{% url ietf.ipr.new.update ipr.ipr_id %}" rel="nofollow">Update this IPR disclosure</a>. Note: Updates to IPR disclosures must only be made by authorized
88+
representatives of the original submitters. Updates will automatically
89+
be forwarded to the current Patent Holder's Contact and to the Submitter
90+
of the original IPR disclosure.</p>
8891
<!-- tag 1 -->
8992
<p><strong>Submitted Date: {{ ipr.submitted_date|date:"F j, Y" }}</strong></p>
9093
{% endif %}
@@ -100,9 +103,7 @@ <h1>{{ ipr.title|escape }}</h1>
100103
</th>
101104
</tr>
102105
<tr class="{% cycle row_parity %}">
103-
{% block section1_data %}
104106
<td class="iprlabel">Legal Name:</td> <td class="iprdata">{{ ipr.legal_name|escape }}</td>
105-
{% endblock %}
106107
</tr>
107108
</table>
108109
{% endif %}

ietf/templates/ipr/disclosure.html

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@ <h1>IPR Disclosure Page</h1>
2323
<li><a href="{% url ietf.ipr.new.new "specific" %}">File a disclosure about your IPR related to a specific IETF contribution</a></li>
2424
<li><a href="{% url ietf.ipr.new.new "generic" %}">File an IPR disclosure that is not related to a specific IETF contribution</a></li>
2525
<li><a href="{% url ietf.ipr.new.new "third-party" %}">Notify the IETF of IPR other than your own</a></li>
26-
<li><a href="{% url ietf.ipr.views.updatelist %}">Update an existing IPR disclosure</a></li>
26+
<li>To update an existing IPR disclosure, find the original disclosure and select "update this IPR disclosure".</li>
2727
<li><a href="{% url ietf.ipr.search.search %}">Search the IPR disclosures</a></li>
2828
<li><a href="{% url ietf.ipr.views.showlist %}">List of IPR disclosures</a></li>
2929
</ul>

ietf/templates/ipr/update_list.html

Lines changed: 0 additions & 70 deletions
This file was deleted.

0 commit comments

Comments
 (0)