Skip to content

Commit b8815b0

Browse files
committed
Don't use person.plain_name() when constructing email addresses, as it can contain unicode characters which the current email pipeline can't handle correctly. Use person.plain_ascii() instead (or person.formatted_email()).
- Legacy-Id: 12865
1 parent 3d56952 commit b8815b0

1 file changed

Lines changed: 1 addition & 3 deletions

File tree

ietf/doc/views_review.py

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -559,9 +559,7 @@ def complete_review(request, name, request_id):
559559
if need_to_email_review:
560560
# email the review
561561
subject = "{} of {}-{}".format("Partial review" if review_req.state_id == "part-completed" else "Review", review_req.doc.name, review_req.reviewed_rev)
562-
msg = send_mail(request, to,
563-
(request.user.person.plain_name(),request.user.person.email_address()),
564-
subject,
562+
msg = send_mail(request, to, request.user.person.formatted_email(), subject,
565563
"review/completed_review.txt", {
566564
"review_req": review_req,
567565
"content": encoded_content.decode("utf-8"),

0 commit comments

Comments
 (0)