Skip to content

Commit b6c3a8f

Browse files
committed
Add IETF sessions to the types that emit parent group name in the session assignment slug, so that the parent group name will be present on the HTML row ID in the agenda for IAB sessions. Also update the wording on special sessions. Fixes ietf-tools#3034. Commit ready for merge.
- Legacy-Id: 18282
1 parent 249090f commit b6c3a8f

3 files changed

Lines changed: 43 additions & 2 deletions

File tree

ietf/meeting/models.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -815,7 +815,7 @@ def slug(self):
815815
components.append("1plenary")
816816
else:
817817
p = getattr(g, "historic_parent", None) or g.parent
818-
if p and p.type_id in ("area", "irtf"):
818+
if p and p.type_id in ("area", "irtf", 'ietf'):
819819
components.append(p.acronym)
820820

821821
components.append(g.acronym)

ietf/meeting/tests_views.py

Lines changed: 41 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -226,6 +226,47 @@ def test_meeting_agenda(self):
226226
self.assertContains(r, session.group.acronym)
227227
self.assertContains(r, slot.location.name)
228228

229+
def test_agenda_iab_session(self):
230+
date = datetime.date.today()
231+
meeting = MeetingFactory(type_id='ietf', date=date )
232+
make_meeting_test_data(meeting=meeting)
233+
234+
iab = Group.objects.get(acronym='iab')
235+
venus = Group.objects.create(
236+
name="Three letter acronym",
237+
acronym="venus",
238+
description="This group discusses exploration of Venus",
239+
state_id="active",
240+
type_id="program",
241+
parent=iab,
242+
list_email="venus@ietf.org",
243+
)
244+
venus_session = Session.objects.create(
245+
meeting=meeting,
246+
group=venus,
247+
attendees=10,
248+
requested_duration=datetime.timedelta(minutes=60),
249+
type_id='regular',
250+
)
251+
system_person = Person.objects.get(name="(System)")
252+
SchedulingEvent.objects.create(session=venus_session, status_id='schedw', by=system_person)
253+
room = Room.objects.create(meeting=meeting,
254+
name="Aphrodite",
255+
capacity=100,
256+
functional_name="Aphrodite Room")
257+
room.session_types.add('regular')
258+
session_date = meeting.date + datetime.timedelta(days=1)
259+
slot3 = TimeSlot.objects.create(meeting=meeting, type_id='regular', location=room,
260+
duration=datetime.timedelta(minutes=60),
261+
time=datetime.datetime.combine(session_date, datetime.time(13, 30)))
262+
SchedTimeSessAssignment.objects.create(timeslot=slot3, session=venus_session, schedule=meeting.schedule)
263+
url = urlreverse('ietf.meeting.views.agenda', kwargs=dict(num=meeting.number))
264+
r = self.client.get(url)
265+
self.assertContains(r, 'venus')
266+
q = PyQuery(r.content)
267+
venus_row = q('[id*="-iab-"]').html()
268+
self.assertIn('venus', venus_row)
269+
229270
def test_agenda_current_audio(self):
230271
date = datetime.date.today()
231272
meeting = MeetingFactory(type_id='ietf', date=date )

ietf/templates/meeting/agenda.html

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -118,7 +118,7 @@ <h4 class="panel-title">
118118
{% else %}
119119
<blockquote><i>No WG / RG data available -- no WG / RG sessions have been scheduled yet.</i></blockquote>
120120
{% endif %}
121-
<p>Also show sessions of these groups:</p>
121+
<p>Also show special sessions of these groups:</p>
122122
<div class="btn-group btn-group-justified">
123123
<div class="btn-group"><button class="btn btn-default pickviewneg active iepg"> IEPG</button></div>
124124
<div class="btn-group"><button class="btn btn-default pickviewneg active tools"> Tools</button></div>

0 commit comments

Comments
 (0)