Skip to content

Commit b3b0c7d

Browse files
committed
Add the header to the contact info request screen:
type and title of IPR being updated. Also, use get_object_or_404 to avoid exceptions. - Legacy-Id: 821
1 parent 23372a7 commit b3b0c7d

2 files changed

Lines changed: 12 additions & 10 deletions

File tree

ietf/ipr/new.py

Lines changed: 10 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@
66
import django.newforms as forms
77

88
from datetime import datetime
9-
from django.shortcuts import render_to_response as render
9+
from django.shortcuts import render_to_response as render, get_object_or_404
1010
from django.template import RequestContext
1111
from django.http import Http404
1212
from ietf.utils import log
@@ -313,6 +313,14 @@ def clean_licensing_option(self):
313313

314314
def update(request, ipr_id=None):
315315
"""Update a specific IPR disclosure"""
316+
ipr = get_object_or_404(models.IprDetail, ipr_id=ipr_id)
317+
if not ipr.status in [1,3]:
318+
raise Http404
319+
type = "specific"
320+
if ipr.generic:
321+
type = "generic"
322+
if ipr.third_party:
323+
type = "third-party"
316324
# We're either asking for initial permission or we're in
317325
# the general ipr form. If the POST argument has the first
318326
# field of the ipr form, then we must be dealing with that,
@@ -332,18 +340,10 @@ def __init__(self, *args, **kwargs):
332340
if not(form.is_valid()):
333341
for error in form.errors:
334342
log("Form error for field: %s: %s"%(error, form.errors[error]))
335-
return render("ipr/update.html", {"form": form}, context_instance=RequestContext(request))
343+
return render("ipr/update.html", {"form": form, "ipr": ipr, "type": type}, context_instance=RequestContext(request))
336344
else:
337345
submitter = form.clean_data
338346

339-
ipr = models.IprDetail.objects.get(ipr_id=ipr_id)
340-
if not ipr.status in [1,3]:
341-
raise Http404
342-
type = "specific"
343-
if ipr.generic:
344-
type = "generic"
345-
if ipr.third_party:
346-
type = "third-party"
347347
return new(request, type, ipr, submitter)
348348

349349

ietf/templates/ipr/update.html

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,8 @@
55

66
{% include "ipr/style.html" %}
77

8+
<h4><font color="#000055"><center>Updating {{ type|title }} IPR Disclosures <br><i>{{ ipr.title|escape }}</i></center></font></h4>
9+
810
<form name="form1" method="post">
911
{% if form.errors %}
1012
<p class="errorlist">

0 commit comments

Comments
 (0)