Skip to content

Commit b29e096

Browse files
committed
Added a test for the IESG past documents page, and tweaked some test documents to have titles.
- Legacy-Id: 14303
1 parent f0cee14 commit b29e096

2 files changed

Lines changed: 39 additions & 4 deletions

File tree

ietf/iesg/tests.py

Lines changed: 31 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -379,6 +379,37 @@ def test_agenda_documents(self):
379379
self.assertTrue(d.name in unicontent(r), "%s not in response" % k)
380380
self.assertTrue(d.title in unicontent(r), "%s title not in response" % k)
381381

382+
def test_past_documents(self):
383+
url = urlreverse("ietf.iesg.views.past_documents")
384+
# We haven't put any documents on past telechats, so this should be empty
385+
r = self.client.get(url)
386+
self.assertEqual(r.status_code, 200)
387+
for k, d in self.telechat_docs.iteritems():
388+
self.assertNotIn(d.name, unicontent(r))
389+
self.assertNotIn(d.title, unicontent(r))
390+
# Add the documents to a past telechat
391+
by = Person.objects.get(name="Areað Irector")
392+
date = datetime.date.today() - datetime.timedelta(days=14)
393+
approved = State.objects.get(type='draft-iesg', slug='approved')
394+
iesg_eval = State.objects.get(type='draft-iesg', slug='iesg-eva')
395+
for d in self.telechat_docs.values():
396+
TelechatDocEvent.objects.create(type="scheduled_for_telechat",
397+
doc=d, rev=d.rev, by=by, telechat_date=date, returning_item=False)
398+
s = d.get_state('draft-iesg')
399+
d.states.clear()
400+
if s and s.slug == 'pub-req':
401+
d.states.add(iesg_eval)
402+
else:
403+
d.states.add(approved)
404+
# Now check that they are present on the past documents page
405+
r = self.client.get(url)
406+
self.assertEqual(r.status_code, 200)
407+
for k, d in self.telechat_docs.iteritems():
408+
if d.states.get(type='draft-iesg').slug in ['approved', 'iesg-eva', ]:
409+
self.assertIn(d.name, unicontent(r))
410+
else:
411+
self.assertNotIn(d.name, unicontent(r))
412+
382413
def test_agenda_telechat_docs(self):
383414
d1 = self.telechat_docs["ietf_draft"]
384415
d2 = self.telechat_docs["ise_draft"]

ietf/utils/test_data.py

Lines changed: 8 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -377,22 +377,26 @@ def make_test_data():
377377
)
378378

379379
# an independent submission before review
380-
doc = Document.objects.create(name='draft-imaginary-independent-submission',type_id='draft',rev='00')
380+
doc = Document.objects.create(name='draft-imaginary-independent-submission',type_id='draft',rev='00',
381+
title="Some Independent Notes on Imagination")
381382
doc.set_state(State.objects.get(used=True, type="draft", slug="active"))
382383
DocAlias.objects.create(name=doc.name, document=doc)
383384

384385
# an irtf submission mid review
385-
doc = Document.objects.create(name='draft-imaginary-irtf-submission', type_id='draft',rev='00', stream=StreamName.objects.get(slug='irtf'))
386+
doc = Document.objects.create(name='draft-imaginary-irtf-submission', type_id='draft',rev='00',
387+
stream=StreamName.objects.get(slug='irtf'), title="The Importance of Research Imagination")
386388
docalias = DocAlias.objects.create(name=doc.name, document=doc)
387389
doc.set_state(State.objects.get(type="draft", slug="active"))
388-
crdoc = Document.objects.create(name='conflict-review-imaginary-irtf-submission', type_id='conflrev', rev='00', notify="fsm@ietf.org")
390+
crdoc = Document.objects.create(name='conflict-review-imaginary-irtf-submission', type_id='conflrev',
391+
rev='00', notify="fsm@ietf.org", title="Conflict Review of IRTF Imagination Document")
389392
DocAlias.objects.create(name=crdoc.name, document=crdoc)
390393
crdoc.set_state(State.objects.get(name='Needs Shepherd', type__slug='conflrev'))
391394
crdoc.relateddocument_set.create(target=docalias,relationship_id='conflrev')
392395

393396
# A status change mid review
394397
iesg = Group.objects.get(acronym='iesg')
395-
doc = Document.objects.create(name='status-change-imaginary-mid-review',type_id='statchg', rev='00', notify="fsm@ietf.org",group=iesg)
398+
doc = Document.objects.create(name='status-change-imaginary-mid-review',type_id='statchg', rev='00',
399+
notify="fsm@ietf.org", group=iesg, title="Status Change Review without Imagination")
396400
doc.set_state(State.objects.get(slug='needshep',type__slug='statchg'))
397401
docalias = DocAlias.objects.create(name='status-change-imaginary-mid-review',document=doc)
398402

0 commit comments

Comments
 (0)