Skip to content

Commit b243d4a

Browse files
committed
Merged in [19670] from rjsparks@nostrum.com:
Escape . in agenda url patterns. Guard against unrecognized extensions. - Legacy-Id: 19671 Note: SVN reference [19670] has been migrated to Git commit 58bd89c
2 parents 4f0a3c3 + 58bd89c commit b243d4a

2 files changed

Lines changed: 5 additions & 3 deletions

File tree

ietf/meeting/urls.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -64,9 +64,9 @@
6464
]
6565

6666
type_ietf_only_patterns_id_optional = [
67-
url(r'^agenda(?P<utc>-utc)?(?P<ext>.html)?/?$', views.agenda),
68-
url(r'^agenda(?P<ext>.txt)$', views.agenda),
69-
url(r'^agenda(?P<ext>.csv)$', views.agenda),
67+
url(r'^agenda(?P<utc>-utc)?(?P<ext>\.html)?/?$', views.agenda),
68+
url(r'^agenda(?P<ext>\.txt)$', views.agenda),
69+
url(r'^agenda(?P<ext>\.csv)$', views.agenda),
7070
url(r'^agenda/edit$',
7171
RedirectView.as_view(pattern_name='ietf.meeting.views.edit_meeting_schedule', permanent=True),
7272
name='ietf.meeting.views.edit_meeting_schedule'),

ietf/meeting/views.py

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1488,6 +1488,8 @@ def agenda(request, num=None, name=None, base=None, ext=None, owner=None, utc=""
14881488
".txt": "text/plain; charset=%s"%settings.DEFAULT_CHARSET,
14891489
".csv": "text/csv; charset=%s"%settings.DEFAULT_CHARSET,
14901490
}
1491+
if ext not in mimetype:
1492+
raise Http404('Extension not allowed')
14911493

14921494
# We do not have the appropriate data in the datatracker for IETF 64 and earlier.
14931495
# So that we're not producing misleading pages...

0 commit comments

Comments
 (0)