Skip to content

Commit b090f1e

Browse files
committed
Merged [5903] from adam@nostrum.com:
Added tooltip capability to document tabs, and tooltips for disabled IESG Evaluation/Review tab. Fixes bug ietf-tools#448. - Legacy-Id: 5931 Note: SVN reference [5903] has been migrated to Git commit d87379c
2 parents d787997 + d87379c commit b090f1e

2 files changed

Lines changed: 4 additions & 4 deletions

File tree

ietf/doc/views_doc.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -57,9 +57,9 @@ def render_document_top(request, doc, tab, name):
5757
ballot = doc.latest_event(BallotDocEvent, type="created_ballot")
5858
if doc.type_id in ("draft","conflrev", "statchg"):
5959
# if doc.in_ietf_process and doc.ietf_process.has_iesg_ballot:
60-
tabs.append(("IESG Evaluation Record", "ballot", urlreverse("doc_ballot", kwargs=dict(name=name)), ballot))
60+
tabs.append(("IESG Evaluation Record", "ballot", urlreverse("doc_ballot", kwargs=dict(name=name)), ballot, None if ballot else "IESG Evaluation Ballot has not been created yet"))
6161
elif doc.type_id == "charter":
62-
tabs.append(("IESG Review", "ballot", urlreverse("doc_ballot", kwargs=dict(name=name)), ballot))
62+
tabs.append(("IESG Review", "ballot", urlreverse("doc_ballot", kwargs=dict(name=name)), ballot, None if ballot else "IEST Review Ballot has not been created yet"))
6363

6464
# FIXME: if doc.in_ietf_process and doc.ietf_process.has_iesg_ballot:
6565
if doc.type_id not in ["conflrev", "statchg"]:

ietf/templates/doc/document_top.html

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,8 +2,8 @@ <h1>{{ doc.title }}<br/>{{ name }}</h1>
22

33
<div id="mytabs" class="yui-navset">
44
<ul class="yui-nav">
5-
{% for name, t, url, active in tabs %}
6-
<li {% if t == selected %}class="selected"{% endif %}{% if not active %}class="disabled"{% endif %}><a{% if active %} href="{{ url }}"{% endif %}><em>{{ name }}</em></a></li>
5+
{% for name, t, url, active, tooltip in tabs %}
6+
<li {% if t == selected %}class="selected"{% endif %}{% if tooltip %}title="{{tooltip}}"{% endif %}{% if not active %}class="disabled"{% endif %}><a{% if active %} href="{{ url }}"{% endif %}><em>{{ name }}</em></a></li>
77
{% endfor %}
88
</ul>
99
</div>

0 commit comments

Comments
 (0)