Cleaned up some exceptions that were leading to quiet 500s when setting an official agenda.

The secretariat code being reused expects querysets, not lists.
Some objects needed to be saved before other functions tried to operate on them.
 - Legacy-Id: 7201

Author: rjsparks

ietf/meeting/models.py

@@ -208,9 +208,9 @@ def vtimezone(self):
     def set_official_agenda(self, agenda):
         if self.agenda != agenda:
             self.agenda = agenda
+            self.save()
             if self.agenda is not None:
                 self.agenda.sendEmail()
-            self.save()
 
     class Meta:
         ordering = ["-date", ]
@@ -612,9 +612,9 @@ def sendEmail(self):
             if session.status.slug == "schedw":
                 session.status_id = "sched"
                 session.scheduled = datetime.datetime.now()
-                import ietf.secr.meetings.views
-                ietf.secr.meetings.views.send_notification(None, [session])
                 session.save()
+                from ietf.secr.meetings.views import send_notification
+                send_notification(None, Session.objects.filter(id=session.id))
 
 # to be renamed ScheduleTimeslotSessionAssignments (stsa)
 class ScheduledSession(models.Model):

ietf/secr/meetings/views.py

@@ -172,7 +172,7 @@ def send_notification(request, sessions):
     to_email = sessions[0].requested_by.role_email('chair').address
     cc_list = get_cc_list(group, requestinguser)
     from_email = ('"IETF Secretariat"','agenda@ietf.org')
-    if sessions.count() == 1:
+    if len(sessions) == 1:
         subject = '%s - Requested session has been scheduled for IETF %s' % (group.acronym, sessions[0].meeting.number)
     else:
         subject = '%s - Requested sessions have been scheduled for IETF %s' % (group.acronym, sessions[0].meeting.number)
@@ -198,6 +198,8 @@ def send_notification(request, sessions):
     context['agenda_note'] = sessions[0].agenda_note
     context['session'] = get_initial_session(sessions)
     context['session_info'] = session_info
+    context['group'] = group
+    context['login'] = sessions[0].requested_by
 
     send_mail(request,
               to_email,