Fix a couple of places where we have to handle potential exceptions from the URL reverse() call, because not all old draft names adhere to the current rules. For RFC 1356 the draft name was draft-ietf-iplpdn-x25_isdn (notice the underscore) for which reverse() will fail.

 - Legacy-Id: 2998

Author: levkowetz

ietf/idrfc/views_doc.py

@@ -41,7 +41,7 @@
 from django.utils import simplejson as json
 from django.utils.decorators import decorator_from_middleware
 from django.middleware.gzip import GZipMiddleware
-from django.core.urlresolvers import reverse
+from django.core.urlresolvers import reverse, NoReverseMatch
 
 from ietf import settings
 from ietf.idtracker.models import InternetDraft, IDInternal, BallotInfo, DocumentComment
@@ -189,10 +189,12 @@ def _get_history(doc, versions):
     if doc.is_id_wrapper and doc.draft_status == "Expired" and doc._draft.expiration_date:
         results.append({'is_text':True, 'date':doc._draft.expiration_date, 'text':'Draft expired'})
     if doc.is_rfc_wrapper:
+        text = 'RFC Published'
         if doc.draft_name:
-            text = 'RFC Published (see <a href="%s">%s</a> for earlier history)' % (reverse('doc_view', args=[doc.draft_name]),doc.draft_name)
-        else:
-            text = 'RFC Published'
+            try:
+                text = 'RFC Published (see <a href="%s">%s</a> for earlier history)' % (reverse('doc_view', args=[doc.draft_name]),doc.draft_name)
+            except NoReverseMatch:
+                pass
         results.append({'is_text':True, 'date':doc.publication_date, 'text':text})
 
     # convert plain dates to datetimes (required for sorting)

ietf/templates/idrfc/doc_tab_document.html

@@ -59,9 +59,9 @@
 {% if doc.in_ietf_process %}
 <span id="doc_edit_state_button" class="yui-button yui-link-button" style="margin-left:2px;"><span class="first-child"><a href="{% url doc_change_state name=doc.draft_name %}">Change state</a></span></span>
 
-<span id="doc_edit_info_button" class="yui-button yui-link-button" style="margin-left:2px;"><span class="first-child"><a href="{% url doc_edit_info name=doc.draft_name %}">Edit</a></span></span>
+<span id="doc_edit_info_button" class="yui-button yui-link-button" style="margin-left:2px;">{% url doc_edit_info name=doc.draft_name as doc_edit_url %}{% if doc_edit_url %}<span class="first-child"><a href="{{doc_edit_url}}">Edit</a></span>{% endif %}</span>
 {% else %}
-<span id="doc_add_button" class="yui-button yui-link-button" style="margin-left:2px;"><span class="first-child"><a href="{% url doc_edit_info name=doc.draft_name %}">Add</a></span></span>
+<span id="doc_add_button" class="yui-button yui-link-button" style="margin-left:2px;">{% url doc_edit_info name=doc.draft_name as doc_edit_url %}{% if doc_edit_url %}<span class="first-child"><a href="{{doc_edit_url}}">Add</a></span>{% endif %}</span>
 {% endif %}
 {% endifequal %}