Skip to content

Commit aa7950e

Browse files
committed
Use the same 'Secure' and 'SameSite' cookie settings for application cookies as for session cookies, rather than hardcoded values (DRY).
- Legacy-Id: 18360
1 parent 4712e83 commit aa7950e

1 file changed

Lines changed: 13 additions & 2 deletions

File tree

ietf/cookies/views.py

Lines changed: 13 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -37,9 +37,20 @@ def preferences(request, **kwargs):
3737
response = render(request, "cookies/settings.html", preferences )
3838
for key in new_cookies:
3939
response.set_cookie(key, new_cookies[key],
40-
max_age=settings.PREFERENCES_COOKIE_AGE, secure=True, samesite='None')
40+
max_age=settings.PREFERENCES_COOKIE_AGE,
41+
secure=settings.SESSION_COOKIE_SECURE or None,
42+
httponly=settings.SESSION_COOKIE_HTTPONLY or None,
43+
samesite=settings.SESSION_COOKIE_SAMESITE,
44+
)
4145
for key in del_cookies:
42-
response.delete_cookie(key)
46+
response.delete_cookie(key,
47+
secure=settings.SESSION_COOKIE_SECURE or None,
48+
httponly=settings.SESSION_COOKIE_HTTPONLY or None,
49+
samesite=settings.SESSION_COOKIE_SAMESITE,
50+
)
51+
52+
--- django/http/response.py.or
53+
secure=True, sames)
4354
return response
4455

4556
def new_enough(request, days=None):

0 commit comments

Comments
 (0)