Skip to content

Commit a8907c6

Browse files
committed
Added a check for model changes which haven't been captured in migrations to the release script.
- Legacy-Id: 9590
1 parent 4966e17 commit a8907c6

1 file changed

Lines changed: 9 additions & 6 deletions

File tree

bin/mkrelease

Lines changed: 9 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -166,12 +166,6 @@ DEV="$(printf %d.%d.%d.dev0 $MAJOR $MINOR $NEXT)"
166166

167167
#cd $DIR ??
168168

169-
note "Running the tests suite and writing release coverage data ..."
170-
$do ietf/manage.py test --settings=ietf.settings_releasetest --save-version-coverage=$VER
171-
172-
note "Committing the release coverage data ..."
173-
$do svn commit release-coverage.json -m "Code coverage data for release $VER"
174-
175169
# note "Checking that there's a recent test-crawler log"
176170
# touch -d $RDATE .svn/.latest-commit
177171
# TCLOG=$(ls -t ../test-crawl-*.log | head -n 1)
@@ -182,6 +176,15 @@ changes=$( sed -n "/^$PROJ ($VER.*)/,/^ -- /p" changelog )
182176
[ "$changes" ] || die "No changelog information for $VER found"
183177
note "$changes"
184178

179+
note "Checking that we don't have any model changes that haven't been captured in migrations"
180+
svn makemigrations | tee /dev/stderr | grep "^No changes detected$" || die "Model changes without migrations found."
181+
182+
note "Running the tests suite and writing release coverage data ..."
183+
$do ietf/manage.py test --settings=ietf.settings_releasetest --save-version-coverage=$VER
184+
185+
note "Committing the release coverage data ..."
186+
$do svn commit release-coverage.json -m "Code coverage data for release $VER"
187+
185188
contributors=$(echo "$changes" | sed 's/\.[ \t\n]/ /'| tr -c "a-z0-9.@-" "\n" | sort | uniq | grep '@' | sed -r -e 's/^\.+//' -e 's/\.+$//' -e 's/^/-c /' || true)
186189

187190
note "Set the current time on the release notes in the changelog file"

0 commit comments

Comments
 (0)