Skip to content

Commit a7a195a

Browse files
committed
The template filter keep_spacing can interact badly with wordwrap. Removed it from several places, and made text document display more consistent. Fixes issue ietf-tools#2481.
- Legacy-Id: 14917
1 parent 4e5050a commit a7a195a

5 files changed

Lines changed: 76 additions & 7 deletions

File tree

changelog

Lines changed: 71 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,75 @@
1+
ietfdb (6.76.1) ietf; urgency=medium
2+
3+
**IETF 101 code sprint, release 2**
4+
5+
This release provides improved meeting attendance statistics (under
6+
/stats/meeting/overview/), improved test coverage, additional menu entries,
7+
html template fixes, total page count on the Last Call page, the ability
8+
for ADs to clear ballots themselves without going through the secretariat,
9+
and more. It also changes the default cookie setting for showing or hiding
10+
the duplicate left-hand menu column. (If you don't like the new default, use
11+
the 'User>Preferences' menu item to revert to the old look.)
12+
13+
Again, many thanks to all the contributors!
14+
15+
From the commit log:
16+
17+
* Merged in [14902] from rjsparks@nostrum.com:
18+
Test coverage improvements for ietf/secr/telechat/views.
19+
20+
* Merged in [14900] from rjsparks@nostrum.com:
21+
Improvements to test coverage for ietf/secr/drafts/views.py.
22+
23+
* Merged in [14899] from rjsparks@nostrum.com:
24+
Cleaner charter factory simplifies test code.
25+
26+
* Added submenu to the Statistics menu entry, pointing at the individual
27+
stats pages, and entries for NomComs and Releases.
28+
29+
* Merged in [14896] from rjsparks@nostrum.com:
30+
Improved test coverage for ietf/doc/views_charter.py.
31+
32+
* Fixed the base template to have id='content' for the content also when
33+
not showing the left-hand menu.
34+
35+
* Updated the cookies tests to match the new left_menu default.
36+
37+
* Changed the default setting for the datatracker left-hand menu to
38+
'off'. The top menu is always present, and works well.
39+
40+
* Tweaked the document list iCalendar links to not show for presentations
41+
on days in the past.
42+
43+
* Merged in [14884] from adam@nostrum.com:
44+
Adding page count to last call page.
45+
46+
* Merged in [14883] from adam@nostrum.com:
47+
Adding link to documents in last call to the AD dashboard side menu.
48+
49+
* Merged in [14849] from ben@nostrum.com:
50+
Give ADs the red Clear Ballot button
51+
52+
* Merged in [14880] from rjsparks@nostrum.com:
53+
Added a Draft test suite.
54+
55+
* Merged in [14879] from kivinen@iki.fi:
56+
Backfilled IETF meetings starting from 1 and backfilled the attendee
57+
numbers for them. Modified the overview attendee statistics page to use
58+
different colors for different venue continents.
59+
60+
* Tweaked the meeting registratoin import to deal more gracefully with
61+
too long names and email addresses, and to fill in the total attendees
62+
number for the meeting.
63+
64+
* Tweaked mergeready to accept an additional hold-for-merge file outside
65+
the repository.
66+
67+
-- Henrik Levkowetz <henrik@levkowetz.com> 24 Mar 2018 21:04:22 +0000
68+
69+
170
ietfdb (6.76.0) ietf; urgency=medium
271

3-
**IETF 101 code sprint**
72+
**IETF 101 code sprint, release 1**
473

574
This release contains datatracker bugfixes and enhancements from the IETF-101
675
Code Sprint. It brings new views to merge duplicate person records, fixes
@@ -13,7 +82,7 @@ ietfdb (6.76.0) ietf; urgency=medium
1382
* Merged in [14864] from rjsparks@nostrum.com:
1483
Improved test coverage for ietf.meeting.views.
1584

16-
* Updated Note Well. Fixes issue 2474.
85+
* Updated Note Well. Fixes issue #2474.
1786

1887
* Tweaked person factory ascii name generation to not include periods
1988
inside names.

ietf/templates/doc/document_charter.html

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -204,7 +204,8 @@ <h2>Charter<br><small>{{ doc.canonical_name }}-{{ doc.rev }}</small></h2>
204204
{% endif %}
205205

206206
{% if doc.rev != "" %}
207-
{{ content|safe|keep_spacing|sanitize|wordwrap:80|safe }}
207+
{# this content is already wrapped in 'pre' #}
208+
{{ content|sanitize|maybewordwrap|safe }}
208209
{% endif %}
209210

210211
{% if not snapshot and chartering %}

ietf/templates/doc/document_conflict_review.html

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -141,7 +141,6 @@ <h2>Conflict review<br><small>{{ conflictdoc.name }}-{{ conflictdoc.rev }}</smal
141141
{% endif %}
142142

143143
{% if doc.rev %}
144-
<p></p>
145-
{{ content|fill:"80"|safe|linebreaksbr|keep_spacing|sanitize }}
144+
<pre> {{ content|sanitize|maybewordwrap|safe }}</pre>
146145
{% endif %}
147146
{% endblock %}

ietf/templates/doc/document_material.html

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -124,7 +124,7 @@
124124
<h2>{% if doc.meeting_related %}Meeting{% endif %} {{ doc.type.name }}<br><small>{{ doc.name }}</small></h2>
125125

126126
{% if doc.rev and content != None %}
127-
{{ content|maybewordwrap|safe|linebreaksbr|keep_spacing|sanitize }}
127+
<pre> {{ content|sanitize|maybewordwrap|safe }}</pre>
128128
{% else %}
129129
<p>Not available as plain text.</p>
130130

ietf/templates/doc/document_status_change.html

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -155,7 +155,7 @@
155155
</p>
156156

157157
{% if doc.rev %}
158-
{{ content|fill:"80"|safe|linebreaksbr|keep_spacing|sanitize }}
158+
<pre> {{ content|sanitize|maybewordwrap|safe }}</pre>
159159
{% endif %}
160160

161161
{% endblock %}

0 commit comments

Comments
 (0)