Skip to content

Commit a68c154

Browse files
authored
fix: Always word-wrap person names in person_link links (ietf-tools#3657)
* fix: Always word-wrap person names in person_link links Defaulting to "text-nowrap" causes too many issues on narrow screens. * Remove extra space
1 parent c2cba85 commit a68c154

5 files changed

Lines changed: 8 additions & 9 deletions

File tree

ietf/templates/iesg/discusses.html

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -57,11 +57,11 @@ <h1>IESG discuss positions</h1>
5757
{% endif %}">
5858
<td>{{ doc.displayname_with_link }}</td>
5959
{% include "doc/search/status_columns.html" %}
60-
<td>{% person_link doc.ad nowrap=False %}</td>
60+
<td>{% person_link doc.ad %}</td>
6161
<td>
6262
{% for p in doc.blocking_positions %}
6363
{% if p.is_old_pos %}<span class="text-muted">{% endif %}
64-
{% person_link p.balloter nowrap=False %}
64+
{% person_link p.balloter %}
6565
({% if p.discuss_time %}{{ p.discuss_time|timesince_days }} days ago{% endif %}
6666
{% if doc.get_state_url != "rfc" and p.rev != doc.rev %}for -{{ p.rev }}{% endif %})
6767
<br>

ietf/templates/iesg/past_documents.html

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -46,11 +46,11 @@ <h1>
4646
</td>
4747
<td>{{ doc.telechat }}</td>
4848
{% include "doc/search/status_columns.html" %}
49-
<td>{% person_link doc.ad nowrap=False %}</td>
49+
<td>{% person_link doc.ad %}</td>
5050
<td>
5151
{% for p in doc.blocking_positions %}
5252
{% if p.is_old_pos %}<span class="text-muted">{% endif %}
53-
{% person_link p.balloter nowrap=False %}
53+
{% person_link p.balloter %}
5454
({% if p.discuss_time %}{{ p.discuss_time|timesince_days }} days ago{% endif %}
5555
{% if doc.get_state_url != "rfc" and p.rev != doc.rev %}for -{{ p.rev }}{% endif %})
5656
<br>

ietf/templates/meeting/requests.html

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -58,10 +58,10 @@ <h2 class="mt-5" id="{{ area.grouper.acronym }}">
5858
{% if session.requested_duration %}{{ session.requested_duration|stringformat:"s"|slice:"0:4" }}{% endif %}
5959
</td>
6060
<td>{{ session.attendees|default:"" }}</td>
61-
<td>{% person_link session.requested_by_person nowrap=False %}</td>
61+
<td>{% person_link session.requested_by_person %}</td>
6262
<td>
6363
{% if session.group.ad_role %}
64-
{% person_link session.group.ad_role.person nowrap=False %}
64+
{% person_link session.group.ad_role.person %}
6565
{% endif %}
6666
</td>
6767
<td>

ietf/templates/person/person_link.html

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,4 @@
1-
<span {% if class or nowrap %}class="{% if nowrap %}text-nowrap{% endif %}
2-
{{ class }}"
1+
<span {% if class %}class="{{ class }}"
32
{% endif %}>{% if email or name %}<a {% if class %}class="text-reset"{% endif %}
43
title="{% if title %}{{ title }}{% else %}Datatracker profile of {{ name }}.{% endif %}"
54
{% if email %} href="{% url 'ietf.person.views.profile' email_or_name=email %}" {% else %} href="{% url 'ietf.person.views.profile' email_or_name=name %}" {% endif %}>{{ name }}</a>{% if email and with_email %} <a {% if class %}class="text-reset"{% endif %}

ietf/templates/person/photo.html

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@
1919
{% if name or email %}</a>{% endif %}
2020
<div class="card-body">
2121
<p class="lead mb-1">
22-
{% person_link person with_email=False nowrap=False %}
22+
{% person_link person with_email=False %}
2323
</p>
2424
{% for role in groups %}
2525
<a title="{{ role.group.name }} {{ role.group.type | upper }}"

0 commit comments

Comments
 (0)