Skip to content

Commit a1ed1ae

Browse files
committed
Moved check for session data up to before we try to use it in announcemen.views.confirm.
- Legacy-Id: 11405
1 parent 28829d3 commit a1ed1ae

1 file changed

Lines changed: 7 additions & 7 deletions

File tree

ietf/secr/announcement/views.py

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -76,8 +76,14 @@ def main(request):
7676
@check_for_cancel('../')
7777
def confirm(request):
7878

79+
if request.session.get('data',None):
80+
data = request.session['data']
81+
else:
82+
messages.error(request, 'No session data. Your session may have expired or cookies are disallowed.')
83+
return redirect('announcement')
84+
7985
if request.method == 'POST':
80-
form = AnnounceForm(request.session['data'],user=request.user)
86+
form = AnnounceForm(data, user=request.user)
8187
message = form.save(user=request.user,commit=True)
8288
extra = {'Reply-To':message.reply_to}
8389
send_mail_text(None,
@@ -95,12 +101,6 @@ def confirm(request):
95101
messages.success(request, 'The announcement was sent.')
96102
return redirect('announcement')
97103

98-
if request.session.get('data',None):
99-
data = request.session['data']
100-
else:
101-
messages.error(request, 'No session data. Your session may have expired or cookies are disallowed.')
102-
return redirect('announcement')
103-
104104
if data['to'] == 'Other...':
105105
to = ','.join(data['to_custom'])
106106
else:

0 commit comments

Comments
 (0)