Skip to content

Commit a11cdd3

Browse files
committed
Expanded iCanendar generation to include interim meetings.
- Legacy-Id: 14763
1 parent fac3053 commit a11cdd3

3 files changed

Lines changed: 21 additions & 6 deletions

File tree

changelog

Lines changed: 17 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -12,15 +12,15 @@ ietfdb (6.75.0) ietf; urgency=medium
1212

1313
Considering this, it seems that a good and general approach would be to do
1414
what is often called 'sanitization' of uploaded html content. (Uploaded
15-
text and markdown documents won't be affected).
15+
text/plain and markdown documents won't be affected).
1616

1717
This release introduces such sanitization.
1818

1919
The cost of this is that if you upload agendas and minutes in HTML format,
2020
you will need to check the results after upload, to make sure that the
2121
agenda and minutes still captures your intent after the sanitization.
2222

23-
Additionally, there is, as usual, some other features and bugfixes:
23+
Additionally, there are, as usual, some other features and bugfixes:
2424

2525
* Added sanitization of uploaded html content for session agendas and
2626
minutes, and did some refactoring of the upload form classes.
@@ -29,8 +29,19 @@ ietfdb (6.75.0) ietf; urgency=medium
2929
to bleach, and upgraded the requirements to let us use the latest html5lib
3030
and bleach.
3131

32-
* Modified the sanitizer and upload handler to strip also the content of
33-
some tags, and to produce valid files (if the content is otherwise valid).
32+
* Modified the sanitizer and upload handler to strip not only the tags, but
33+
also the content of some tags, and to produce valid files (if the content
34+
is otherwise valid) by wrapping the content in appropriate <html> and
35+
<body> tags.
36+
37+
* If there are both WG milestone changes and a deletion marked for a
38+
specific milesone, show both 'Changed' and 'Deleted' labels on the
39+
milestone review form.
40+
41+
* Changed the handling of the milestone edit form to defer deletion if it is
42+
requested together with other changes to the same milestone. Instead show
43+
a warning, and ask that deletion be done without simultaneous changes to
44+
the milestone.
3445

3546
* Django's urlize filter does not deal well with adjacent parantheses.
3647
Replaced it with a filter based on bleach.linkify, which does better, and
@@ -63,6 +74,7 @@ ietfdb (6.75.0) ietf; urgency=medium
6374

6475
-- Henrik Levkowetz <henrik@levkowetz.com> 06 Mar 2018 14:38:42 -0800
6576

77+
6678
ietfdb (6.74.0) ietf; urgency=medium
6779

6880
**Various notificaiton email improvements and additional iCalendar links**
@@ -114,6 +126,7 @@ ietfdb (6.74.0) ietf; urgency=medium
114126

115127
-- Henrik Levkowetz <henrik@levkowetz.com> 04 Mar 2018 16:07:35 +0000
116128

129+
117130
ietfdb (6.73.0) ietf; urgency=medium
118131

119132
**Django 1.11**

ietf/meeting/urls.py

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -16,6 +16,8 @@
1616
url(r'^session/(?P<session_id>\d+)/slides(?:/%(name)s)?$' % settings.URL_REGEXPS, views.upload_session_slides),
1717
url(r'^session/(?P<session_id>\d+)/slides/%(name)s/order$' % settings.URL_REGEXPS, views.set_slide_order),
1818
url(r'^session/(?P<session_id>\d+)/doc/%(name)s/remove$' % settings.URL_REGEXPS, views.remove_sessionpresentation),
19+
url(r'^session/(?P<session_id>\d+)\.ics$', views.ical_agenda),
20+
url(r'^session/(?P<acronym>[-a-z0-9]+).ics$', views.ical_agenda),
1921
]
2022

2123

ietf/meeting/views.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -829,11 +829,11 @@ def room_view(request, num=None, name=None, owner=None):
829829
return render(request, template,{"meeting":meeting,"schedule":schedule,"unavailable":unavailable,"assignments":assignments,"rooms":rooms,"days":days})
830830

831831
def ical_agenda(request, num=None, name=None, acronym=None, session_id=None):
832-
meeting = get_meeting(num)
832+
meeting = get_meeting(num, type_in=None)
833833
schedule = get_schedule(meeting, name)
834834
updated = meeting.updated()
835835

836-
if schedule is None:
836+
if schedule is None and acronym is None and session_id is None:
837837
raise Http404
838838

839839
q = request.META.get('QUERY_STRING','') or ""

0 commit comments

Comments
 (0)