Skip to content

Commit 9c173f4

Browse files
committed
Merged in [18821] from rjsparks@nostrum.com:
Add proper folding for static content in the DESCRIPTION in the important-dates ics feed. Remove important-dates from the upcoming meetings ics. - Legacy-Id: 18824 Note: SVN reference [18821] has been migrated to Git commit 7620642
2 parents 42bd8f5 + 7620642 commit 9c173f4

5 files changed

Lines changed: 21 additions & 17 deletions

File tree

ietf/meeting/tests_views.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2297,14 +2297,14 @@ def test_upcoming_ical(self):
22972297
r = self.client.get(url)
22982298

22992299
self.assertEqual(r.status_code, 200)
2300-
# Expect events for important dates plus 3 - one for each WG and one for the IETF meeting
2300+
# Expect events 3 sessions - one for each WG and one for the IETF meeting
23012301
assert_ical_response_is_valid(self, r,
23022302
expected_event_summaries=[
23032303
'ames - Asteroid Mining Equipment Standardization Group',
23042304
'mars - Martian Special Interest Group',
23052305
'IETF 72',
23062306
],
2307-
expected_event_count=3 + meeting.importantdate_set.count())
2307+
expected_event_count=3)
23082308

23092309
def test_upcoming_ical_filter(self):
23102310
# Just a quick check of functionality - details tested by test_js.InterimTests

ietf/templates/meeting/important_dates_for_meeting.ics

Lines changed: 15 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -4,19 +4,20 @@ SUMMARY:IETF {{ meeting.number }}: {{ d.name.name }}
44
CLASS:PUBLIC
55
DTSTART{% if not d.midnight_cutoff %};VALUE=DATE{% endif %}:{{ d.date|date:"Ymd" }}{% if d.midnight_cutoff %}235900Z{% endif %}
66
DTSTAMP:{{ meeting.cached_updated|date:"Ymd" }}T{{ meeting.cached_updated|date:"His" }}Z
7-
DESCRIPTION:{{ d.name.desc }} {% if first and d.name.slug == 'openreg' or first and d.name.slug == 'earlybird' %}
8-
Register here: https://www.ietf.org/how/meetings/register/{% endif %}{% if d.name.slug == 'opensched' %}
9-
To request a Working Group session, use the IETF Meeting Session Request Tool:
10-
{{ request.scheme }}://{{ request.get_host}}{% url 'ietf.secr.sreq.views.main' %}
11-
If you are working on a BoF request, it is highly recommended to tell the IESG
12-
now by sending an email to iesg@ietf.org to get advance help with the request.{% endif %}{% if d.name.slug == 'cutoffwgreq' %}
13-
To request a Working Group session, use the IETF Meeting Session Request Tool:
14-
{{ request.scheme }}://{{ request.get_host }}{% url 'ietf.secr.sreq.views.main' %}{% endif %}{% if d.name.slug == 'cutoffbofreq' %}
15-
To request a BOF, please see instructions on Requesting a BOF:
16-
https://www.ietf.org/how/bofs/bof-procedures/{% endif %}{% if d.name.slug == 'idcutoff' %}
17-
Upload using the ID Submission Tool:
18-
{{ request.scheme }}://{{ request.get_host }}{% url 'ietf.submit.views.upload_submission' %}{% endif %}{% if d.name.slug == 'draftwgagenda' or d.name.slug == 'revwgagenda' or d.name.slug == 'procsub' or d.name.slug == 'revslug' %}
19-
Upload using the Meeting Materials Management Tool:
20-
{{ request.scheme }}://{{ request.get_host }}{% url 'ietf.meeting.views.materials' num=meeting.number %}{% endif %}
7+
TRANSP:TRANSPARENT
8+
DESCRIPTION:{{ d.name.desc }}{% if first and d.name.slug == 'openreg' or first and d.name.slug == 'earlybird' %}\n
9+
Register here: https://www.ietf.org/how/meetings/register/{% endif %}{% if d.name.slug == 'opensched' %}\n
10+
To request a Working Group session, use the IETF Meeting Session Request Tool:\n
11+
{{ request.scheme }}://{{ request.get_host}}{% url 'ietf.secr.sreq.views.main' %}\n
12+
If you are working on a BoF request, it is highly recommended to tell the IESG\n
13+
now by sending an email to iesg@ietf.org to get advance help with the request.{% endif %}{% if d.name.slug == 'cutoffwgreq' %}\n
14+
To request a Working Group session, use the IETF Meeting Session Request Tool:\n
15+
{{ request.scheme }}://{{ request.get_host }}{% url 'ietf.secr.sreq.views.main' %}{% endif %}{% if d.name.slug == 'cutoffbofreq' %}\n
16+
To request a BOF, please see instructions on Requesting a BOF:\n
17+
https://www.ietf.org/how/bofs/bof-procedures/{% endif %}{% if d.name.slug == 'idcutoff' %}\n
18+
Upload using the ID Submission Tool:\n
19+
{{ request.scheme }}://{{ request.get_host }}{% url 'ietf.submit.views.upload_submission' %}{% endif %}{% if d.name.slug == 'draftwgagenda' or d.name.slug == 'revwgagenda' or d.name.slug == 'procsub' or d.name.slug == 'revslug' %}\n
20+
Upload using the Meeting Materials Management Tool:\n
21+
{{ request.scheme }}://{{ request.get_host }}{% url 'ietf.meeting.views.materials' num=meeting.number %}{% endif %}
2122
END:VEVENT
2223
{% endfor %}

ietf/templates/meeting/upcoming.html

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -30,6 +30,7 @@ <h1>Upcoming Meetings
3030
</h1>
3131

3232
<p>For more on regular IETF meetings see <a href="https://www.ietf.org/meeting/upcoming.html">here</a></p>
33+
<p>Meeting important dates are not included in upcoming meeting calendars. They have <a href="{% url 'ietf.meeting.views.important_dates' %}">their own calendar</a></p>
3334

3435
{% include 'meeting/agenda_filter.html' with filter_categories=filter_categories customize_button_text="Customize the meeting list..." only%}
3536

ietf/templates/meeting/upcoming.ics

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -28,4 +28,4 @@ DTEND;VALUE=DATE{% if meeting.time_zone %};TZID={{ meeting.time_zone|ics_esc }}{
2828
DTSTAMP:{{ meeting.cached_updated|date:"Ymd" }}T{{ meeting.cached_updated|date:"His" }}Z
2929
URL:{{ request.scheme }}://{{ request.get_host }}{% url 'ietf.meeting.views.agenda' num=meeting.number %}
3030
END:VEVENT
31-
{% include "meeting/important_dates_for_meeting.ics" %}{% endfor %}END:VCALENDAR{% endautoescape %}
31+
{% endfor %}END:VCALENDAR{% endautoescape %}

ready-for-merge

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,8 @@
77

88
# --- Add entries at the top ---
99

10+
/personal/rjs/7.25.1.dev0@18821
11+
1012
/personal/rcross/7.19.1.dev0@18729
1113

1214
/personal/housley/7.22.1.dev0@18719

0 commit comments

Comments
 (0)