Skip to content

Commit 9454c8b

Browse files
committed
Show other reviews of document on the review document page
- Legacy-Id: 11784
1 parent 1ae302c commit 9454c8b

4 files changed

Lines changed: 30 additions & 11 deletions

File tree

ietf/doc/views_doc.py

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -579,6 +579,10 @@ def document_main(request, name, rev=None):
579579

580580
review_req = ReviewRequest.objects.filter(review=doc.name).first()
581581

582+
other_reviews = []
583+
if review_req:
584+
other_reviews = ReviewRequest.objects.filter(doc=review_req.doc, state__in=["completed", "part-completed"]).exclude(pk=review_req.pk).order_by("-time", "-id")
585+
582586
return render(request, "doc/document_review.html",
583587
dict(doc=doc,
584588
top=top,
@@ -587,6 +591,7 @@ def document_main(request, name, rev=None):
587591
latest_rev=latest_rev,
588592
snapshot=snapshot,
589593
review_req=review_req,
594+
other_reviews=other_reviews,
590595
))
591596

592597
raise Http404

ietf/templates/doc/document_draft.html

Lines changed: 2 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -198,17 +198,8 @@
198198
<th>Reviews</th>
199199
<td class="edit"></td>
200200
<td>
201-
{% for r in review_requests %}
202-
<div>
203-
{% if r.state_id == "completed" or r.state_id == "part-completed" %}
204-
<a href="{% if r.review %}{% url "doc_view" r.review.name %}{% else %}{% url "ietf.doc.views_review.review_request" r.doc_id r.pk %}{% endif %}">
205-
{{ r.team.acronym|upper }} {{ r.type.name }} Review{% if r.reviewed_rev and r.reviewed_rev != doc.rev %} (of -{{ r.reviewed_rev }}){% endif %}:
206-
{{ r.result.name }} {% if r.state_id == "part-completed" %}(partially completed){% endif %}
207-
- reviewer: {{ r.reviewer.person }}</a>
208-
{% else %}
209-
<a href="{% url "ietf.doc.views_review.review_request" r.doc_id r.pk %}">{{ r.team.acronym|upper }} {{ r.type.name }} Review{% if r.reviewer %} (reviewer: {{ r.reviewer.person }}){% endif %}</a>
210-
{% endif %}
211-
</div>
201+
{% for review_request in review_requests %}
202+
{% include "doc/review_request_summary.html" with current_rev=doc.rev %}
212203
{% endfor %}
213204

214205
{% if can_request_review %}

ietf/templates/doc/document_review.html

Lines changed: 13 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -92,6 +92,19 @@
9292
<td class="edit"></td>
9393
<td>{{ doc.time|date:"Y-m-d" }}</td>
9494
</tr>
95+
96+
{% if other_reviews %}
97+
<tr>
98+
<th></th>
99+
<th>Other reviews</th>
100+
<td class="edit"></td>
101+
<td>
102+
{% for review_request in other_reviews %}
103+
{% include "doc/review_request_summary.html" with current_rev=review_req.reviewed_rev %}
104+
{% endfor %}
105+
</td>
106+
</tr>
107+
{% endif %}
95108
</tbody>
96109
</table>
97110

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,10 @@
1+
<div class="review-request-summary">
2+
{% if review_request.state_id == "completed" or review_request.state_id == "part-completed" %}
3+
<a href="{% if review_request.review %}{% url "doc_view" review_request.review.name %}{% else %}{% url "ietf.doc.views_review.review_request" review_request.doc_id review_request.pk %}{% endif %}">
4+
{{ review_request.team.acronym|upper }} {{ review_request.type.name }} Review{% if review_request.reviewed_rev and review_request.reviewed_rev != current_rev %} (of -{{ review_request.reviewed_rev }}){% endif %}:
5+
{{ review_request.result.name }} {% if review_request.state_id == "part-completed" %}(partially completed){% endif %}
6+
- reviewer: {{ review_request.reviewer.person }}</a>
7+
{% else %}
8+
<a href="{% url "ietf.doc.views_review.review_request" review_request.doc_id review_request.pk %}">{{ review_request.team.acronym|upper }} {{ review_request.type.name }} Review{% if review_request.reviewer %} (reviewer: {{ review_request.reviewer.person }}){% endif %}</a>
9+
{% endif %}
10+
</div>

0 commit comments

Comments
 (0)