Skip to content

Commit 9221472

Browse files
committed
Renamed some files under ietf/group/ which contained views but didn't have 'views' in the name.
- Legacy-Id: 11190
1 parent 21b2330 commit 9221472

22 files changed

Lines changed: 127 additions & 127 deletions

ietf/group/tests.py

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -68,8 +68,8 @@ def test_group_document_dependency_dotfile(self):
6868
make_test_data()
6969
for group in Group.objects.filter(Q(type="wg") | Q(type="rg")):
7070
client = Client(Accept='text/plain')
71-
for url in [ urlreverse("ietf.group.info.dependencies",kwargs=dict(acronym=group.acronym,output_type="dot")),
72-
urlreverse("ietf.group.info.dependencies",kwargs=dict(acronym=group.acronym,group_type=group.type_id,output_type="dot")),
71+
for url in [ urlreverse("ietf.group.views.dependencies",kwargs=dict(acronym=group.acronym,output_type="dot")),
72+
urlreverse("ietf.group.views.dependencies",kwargs=dict(acronym=group.acronym,group_type=group.type_id,output_type="dot")),
7373
]:
7474
r = client.get(url)
7575
self.assertTrue(r.status_code == 200, "Failed to receive "
@@ -81,8 +81,8 @@ def test_group_document_dependency_pdffile(self):
8181
make_test_data()
8282
for group in Group.objects.filter(Q(type="wg") | Q(type="rg")):
8383
client = Client(Accept='application/pdf')
84-
for url in [ urlreverse("ietf.group.info.dependencies",kwargs=dict(acronym=group.acronym,output_type="pdf")),
85-
urlreverse("ietf.group.info.dependencies",kwargs=dict(acronym=group.acronym,group_type=group.type_id,output_type="pdf")),
84+
for url in [ urlreverse("ietf.group.views.dependencies",kwargs=dict(acronym=group.acronym,output_type="pdf")),
85+
urlreverse("ietf.group.views.dependencies",kwargs=dict(acronym=group.acronym,group_type=group.type_id,output_type="pdf")),
8686
]:
8787
r = client.get(url)
8888
self.assertTrue(r.status_code == 200, "Failed to receive "
@@ -94,8 +94,8 @@ def test_group_document_dependency_svgfile(self):
9494
make_test_data()
9595
for group in Group.objects.filter(Q(type="wg") | Q(type="rg")):
9696
client = Client(Accept='image/svg+xml')
97-
for url in [ urlreverse("ietf.group.info.dependencies",kwargs=dict(acronym=group.acronym,output_type="svg")),
98-
urlreverse("ietf.group.info.dependencies",kwargs=dict(acronym=group.acronym,group_type=group.type_id,output_type="svg")),
97+
for url in [ urlreverse("ietf.group.views.dependencies",kwargs=dict(acronym=group.acronym,output_type="svg")),
98+
urlreverse("ietf.group.views.dependencies",kwargs=dict(acronym=group.acronym,group_type=group.type_id,output_type="svg")),
9999
]:
100100
r = client.get(url)
101101
self.assertTrue(r.status_code == 200, "Failed to receive "
@@ -141,7 +141,7 @@ def test_group_with_mailarch(self):
141141
group = GroupFactory()
142142
group.list_archive = 'https://mailarchive.ietf.org/arch/browse/%s/'%group.acronym
143143
group.save()
144-
url = urlreverse("ietf.group.info.derived_archives",kwargs=dict(acronym=group.acronym))
144+
url = urlreverse("ietf.group.views.derived_archives",kwargs=dict(acronym=group.acronym))
145145
r = self.client.get(url)
146146
self.assertEqual(r.status_code, 200)
147147
q = PyQuery(r.content)
@@ -153,7 +153,7 @@ def test_group_without_mailarch(self):
153153
group = GroupFactory()
154154
group.list_archive = 'https://alienarchive.example.com'
155155
group.save()
156-
url = urlreverse("ietf.group.info.derived_archives",kwargs=dict(acronym=group.acronym))
156+
url = urlreverse("ietf.group.views.derived_archives",kwargs=dict(acronym=group.acronym))
157157
r = self.client.get(url)
158158
self.assertEqual(r.status_code, 200)
159159
q = PyQuery(r.content)

ietf/group/tests_info.py

Lines changed: 38 additions & 38 deletions
Large diffs are not rendered by default.

ietf/group/urls.py

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -3,15 +3,15 @@
33
from django.conf.urls import patterns, include
44

55
urlpatterns = patterns('',
6-
(r'^$', 'ietf.group.info.active_groups'),
7-
(r'^groupmenu.json', 'ietf.group.ajax.group_menu_data', None, "group_menu_data"),
8-
(r'^(?P<acronym>[a-z0-9]+).json$', 'ietf.group.ajax.group_json'),
9-
(r'^chartering/$', 'ietf.group.info.chartering_groups'),
10-
(r'^chartering/create/(?P<group_type>(wg|rg))/$', 'ietf.group.edit.edit', {'action': "charter"}, "group_create"),
11-
(r'^concluded/$', 'ietf.group.info.concluded_groups'),
12-
(r'^email-aliases/$', 'ietf.group.info.email_aliases'),
13-
(r'^all-status/$', 'ietf.group.info.all_status'),
14-
(r'^(?P<acronym>[a-zA-Z0-9-._]+)/$', 'ietf.group.info.group_home', None, "group_home"),
6+
(r'^$', 'ietf.group.views.active_groups'),
7+
(r'^groupmenu.json', 'ietf.group.views_ajax.group_menu_data', None, "group_menu_data"),
8+
(r'^(?P<acronym>[a-z0-9]+).json$', 'ietf.group.views_ajax.group_json'),
9+
(r'^chartering/$', 'ietf.group.views.chartering_groups'),
10+
(r'^chartering/create/(?P<group_type>(wg|rg))/$', 'ietf.group.views_edit.edit', {'action': "charter"}, "group_create"),
11+
(r'^concluded/$', 'ietf.group.views.concluded_groups'),
12+
(r'^email-aliases/$', 'ietf.group.views.email_aliases'),
13+
(r'^all-status/$', 'ietf.group.views.all_status'),
14+
(r'^(?P<acronym>[a-zA-Z0-9-._]+)/$', 'ietf.group.views.group_home', None, "group_home"),
1515
(r'^(?P<acronym>[a-zA-Z0-9-._]+)/', include('ietf.group.urls_info_details')),
1616
)
1717

ietf/group/urls_info.py

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -3,21 +3,21 @@
33
from django.conf.urls import patterns, include
44
from django.views.generic import RedirectView
55

6-
from ietf.group import info, edit
6+
from ietf.group import views, views_edit
77

88
urlpatterns = patterns('',
9-
(r'^$', info.active_groups),
9+
(r'^$', views.active_groups),
1010
(r'^summary.txt', RedirectView.as_view(url='/wg/1wg-summary.txt')),
1111
(r'^summary-by-area.txt', RedirectView.as_view(url='/wg/1wg-summary.txt')),
1212
(r'^summary-by-acronym.txt', RedirectView.as_view(url='/wg/1wg-summary-by-acronym.txt')),
13-
(r'^1wg-summary.txt', info.wg_summary_area),
14-
(r'^1wg-summary-by-acronym.txt', info.wg_summary_acronym),
15-
(r'^1wg-charters.txt', info.wg_charters),
16-
(r'^1wg-charters-by-acronym.txt', info.wg_charters_by_acronym),
13+
(r'^1wg-summary.txt', views.wg_summary_area),
14+
(r'^1wg-summary-by-acronym.txt', views.wg_summary_acronym),
15+
(r'^1wg-charters.txt', views.wg_charters),
16+
(r'^1wg-charters-by-acronym.txt', views.wg_charters_by_acronym),
1717
(r'^chartering/$', RedirectView.as_view(url='/group/chartering/')),
1818
(r'^chartering/create/$', RedirectView.as_view(url='/group/chartering/create/%(group_type)s/')),
19-
(r'^bofs/$', info.bofs),
20-
(r'^email-aliases/$', 'ietf.group.info.email_aliases'),
21-
(r'^bofs/create/$', edit.edit, {'action': "create"}, "bof_create"),
19+
(r'^bofs/$', views.bofs),
20+
(r'^email-aliases/$', 'ietf.group.views.email_aliases'),
21+
(r'^bofs/create/$', views_edit.edit, {'action': "create"}, "bof_create"),
2222
(r'^(?P<acronym>[a-zA-Z0-9-._]+)/', include('ietf.group.urls_info_details')),
2323
)

ietf/group/urls_info_details.py

Lines changed: 18 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -2,31 +2,31 @@
22
from django.views.generic import RedirectView
33

44
urlpatterns = patterns('',
5-
(r'^$', 'ietf.group.info.group_home', None, "group_home"),
6-
(r'^documents/txt/$', 'ietf.group.info.group_documents_txt'),
7-
(r'^documents/$', 'ietf.group.info.group_documents', None, "group_docs"),
5+
(r'^$', 'ietf.group.views.group_home', None, "group_home"),
6+
(r'^documents/txt/$', 'ietf.group.views.group_documents_txt'),
7+
(r'^documents/$', 'ietf.group.views.group_documents', None, "group_docs"),
88
(r'^documents/manage/$', 'ietf.community.views.manage_list'),
99
(r'^documents/csv/$', 'ietf.community.views.export_to_csv'),
1010
(r'^documents/feed/$', 'ietf.community.views.feed'),
1111
(r'^documents/subscription/$', 'ietf.community.views.subscription'),
12-
(r'^charter/$', 'ietf.group.info.group_about', None, 'group_charter'),
13-
(r'^about/$', 'ietf.group.info.group_about', None, 'group_about'),
14-
(r'^about/status/$', 'ietf.group.info.group_about_status'),
15-
(r'^about/status/edit/$', 'ietf.group.info.group_about_status_edit'),
16-
(r'^history/$','ietf.group.info.history'),
17-
(r'^email/$', 'ietf.group.info.email'),
18-
(r'^deps/(?P<output_type>[\w-]+)/$', 'ietf.group.info.dependencies'),
19-
(r'^meetings/$', 'ietf.group.info.meetings'),
20-
(r'^init-charter/', 'ietf.group.edit.submit_initial_charter'),
21-
(r'^edit/$', 'ietf.group.edit.edit', {'action': "edit"}, "group_edit"),
22-
(r'^conclude/$', 'ietf.group.edit.conclude'),
12+
(r'^charter/$', 'ietf.group.views.group_about', None, 'group_charter'),
13+
(r'^about/$', 'ietf.group.views.group_about', None, 'group_about'),
14+
(r'^about/status/$', 'ietf.group.views.group_about_status'),
15+
(r'^about/status/edit/$', 'ietf.group.views.group_about_status_edit'),
16+
(r'^history/$','ietf.group.views.history'),
17+
(r'^email/$', 'ietf.group.views.email'),
18+
(r'^deps/(?P<output_type>[\w-]+)/$', 'ietf.group.views.dependencies'),
19+
(r'^meetings/$', 'ietf.group.views.meetings'),
20+
(r'^init-charter/', 'ietf.group.views_edit.submit_initial_charter'),
21+
(r'^edit/$', 'ietf.group.views_edit.edit', {'action': "edit"}, "group_edit"),
22+
(r'^conclude/$', 'ietf.group.views_edit.conclude'),
2323
(r'^milestones/$', 'ietf.group.milestones.edit_milestones', {'milestone_set': "current"}, "group_edit_milestones"),
2424
(r'^milestones/charter/$', 'ietf.group.milestones.edit_milestones', {'milestone_set': "charter"}, "group_edit_charter_milestones"),
2525
(r'^milestones/charter/reset/$', 'ietf.group.milestones.reset_charter_milestones', None, "group_reset_charter_milestones"),
26-
(r'^workflow/$', 'ietf.group.edit.customize_workflow'),
27-
(r'^materials/$', 'ietf.group.info.materials', None, "group_materials"),
26+
(r'^workflow/$', 'ietf.group.views_edit.customize_workflow'),
27+
(r'^materials/$', 'ietf.group.views.materials', None, "group_materials"),
2828
(r'^materials/new/$', 'ietf.doc.views_material.choose_material_type'),
2929
(r'^materials/new/(?P<doc_type>[\w-]+)/$', 'ietf.doc.views_material.edit_material', { 'action': "new" }, "group_new_material"),
30-
(r'^archives/$', 'ietf.group.info.derived_archives'),
31-
url(r'^email-aliases/$', RedirectView.as_view(pattern_name='ietf.group.info.email',permanent=False),name='old_group_email_aliases'),
30+
(r'^archives/$', 'ietf.group.views.derived_archives'),
31+
url(r'^email-aliases/$', RedirectView.as_view(pattern_name='ietf.group.views.email',permanent=False),name='old_group_email_aliases'),
3232
)
Lines changed: 10 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -338,27 +338,27 @@ def construct_group_menu_context(request, group, selected, group_type, others):
338338
# menu entries
339339
entries = []
340340
if group.features.has_documents:
341-
entries.append(("Documents", urlreverse("ietf.group.info.group_documents", kwargs=kwargs)))
341+
entries.append(("Documents", urlreverse("ietf.group.views.group_documents", kwargs=kwargs)))
342342
if group.features.has_chartering_process:
343343
entries.append(("Charter", urlreverse("group_charter", kwargs=kwargs)))
344344
else:
345345
entries.append(("About", urlreverse("group_about", kwargs=kwargs)))
346346
if group.features.has_materials and get_group_materials(group).exists():
347-
entries.append(("Materials", urlreverse("ietf.group.info.materials", kwargs=kwargs)))
347+
entries.append(("Materials", urlreverse("ietf.group.views.materials", kwargs=kwargs)))
348348
if group.type_id in ('rg','wg','team'):
349-
entries.append(("Meetings", urlreverse("ietf.group.info.meetings", kwargs=kwargs)))
350-
entries.append(("Email expansions", urlreverse("ietf.group.info.email", kwargs=kwargs)))
351-
entries.append(("History", urlreverse("ietf.group.info.history", kwargs=kwargs)))
349+
entries.append(("Meetings", urlreverse("ietf.group.views.meetings", kwargs=kwargs)))
350+
entries.append(("Email expansions", urlreverse("ietf.group.views.email", kwargs=kwargs)))
351+
entries.append(("History", urlreverse("ietf.group.views.history", kwargs=kwargs)))
352352

353353
if group.list_archive.startswith("http:") or group.list_archive.startswith("https:") or group.list_archive.startswith("ftp:"):
354354
if 'mailarchive.ietf.org' in group.list_archive:
355-
entries.append(("List archive", urlreverse("ietf.group.info.derived_archives", kwargs=kwargs)))
355+
entries.append(("List archive", urlreverse("ietf.group.views.derived_archives", kwargs=kwargs)))
356356
else:
357357
entries.append((mark_safe("List archive &raquo;"), group.list_archive))
358358

359359
if group.features.has_documents:
360360
kwargs["output_type"] = "svg"
361-
entries.append((mark_safe("Dependency graph &raquo;"), urlreverse("ietf.group.info.dependencies", kwargs=kwargs)))
361+
entries.append((mark_safe("Dependency graph &raquo;"), urlreverse("ietf.group.views.dependencies", kwargs=kwargs)))
362362
del kwargs["output_type"]
363363

364364
if group.has_tools_page():
@@ -388,10 +388,10 @@ def construct_group_menu_context(request, group, selected, group_type, others):
388388
actions.append((u"Edit group", urlreverse("group_edit", kwargs=kwargs)))
389389

390390
if group.features.customize_workflow and (is_chair or can_manage):
391-
actions.append((u"Customize workflow", urlreverse("ietf.group.edit.customize_workflow", kwargs=kwargs)))
391+
actions.append((u"Customize workflow", urlreverse("ietf.group.views_edit.customize_workflow", kwargs=kwargs)))
392392

393393
if group.state_id in ("active", "dormant") and not group.type_id in ["sdo", "rfcedtyp", "isoc", ] and can_manage:
394-
actions.append((u"Request closing group", urlreverse("ietf.group.edit.conclude", kwargs=kwargs)))
394+
actions.append((u"Request closing group", urlreverse("ietf.group.views_edit.conclude", kwargs=kwargs)))
395395

396396
d = {
397397
"group": group,
@@ -573,7 +573,7 @@ def group_about_status_edit(request, acronym, group_type=None):
573573
type='status_update',
574574
desc=update_text,
575575
)
576-
return redirect('ietf.group.info.group_about',acronym=group.acronym)
576+
return redirect('ietf.group.views.group_about',acronym=group.acronym)
577577
else:
578578
form = None
579579
else:
Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@ def group_menu_data(request):
2323

2424
groups_by_parent = defaultdict(list)
2525
for g in groups:
26-
url = urlreverse("ietf.group.info.group_home", kwargs={ 'group_type': g.type_id, 'acronym': g.acronym })
26+
url = urlreverse("ietf.group.views.group_home", kwargs={ 'group_type': g.type_id, 'acronym': g.acronym })
2727
groups_by_parent[g.parent_id].append({ 'acronym': g.acronym, 'name': escape(g.name), 'url': url })
2828

2929
return JsonResponse(groups_by_parent)
Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -425,7 +425,7 @@ def customize_workflow(request, group_type, acronym):
425425

426426
# redirect so the back button works correctly, otherwise
427427
# repeated POSTs fills up the history
428-
return redirect("ietf.group.edit.customize_workflow", group_type=group.type_id, acronym=group.acronym)
428+
return redirect("ietf.group.views_edit.customize_workflow", group_type=group.type_id, acronym=group.acronym)
429429

430430
if action == "setnextstates":
431431
try:
@@ -442,7 +442,7 @@ def customize_workflow(request, group_type, acronym):
442442
transitions, _ = GroupStateTransitions.objects.get_or_create(group=group, state=state)
443443
transitions.next_states = next_states
444444

445-
return redirect("ietf.group.edit.customize_workflow", group_type=group.type_id, acronym=group.acronym)
445+
return redirect("ietf.group.views_edit.customize_workflow", group_type=group.type_id, acronym=group.acronym)
446446

447447
if action == "settagactive":
448448
active = request.POST.get("active") == "1"
@@ -456,7 +456,7 @@ def customize_workflow(request, group_type, acronym):
456456
else:
457457
group.unused_tags.add(tag)
458458

459-
return redirect("ietf.group.edit.customize_workflow", group_type=group.type_id, acronym=group.acronym)
459+
return redirect("ietf.group.views_edit.customize_workflow", group_type=group.type_id, acronym=group.acronym)
460460

461461
# put some info for the template on tags and states
462462
unused_tags = group.unused_tags.all().values_list('slug', flat=True)

ietf/meeting/tests_api.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -180,7 +180,7 @@ def test_group_json(self):
180180
make_meeting_test_data()
181181
group = Group.objects.get(acronym="mars")
182182

183-
url = urlreverse("ietf.group.ajax.group_json", kwargs=dict(acronym=group.acronym))
183+
url = urlreverse("ietf.group.views_ajax.group_json", kwargs=dict(acronym=group.acronym))
184184
r = self.client.get(url)
185185
self.assertEqual(r.status_code, 200)
186186
info = json.loads(r.content)

ietf/templates/base/menu.html

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -14,9 +14,9 @@
1414
<ul class="dropdown-menu" role="menu">
1515
{% endif %}
1616

17-
<li><a href="{% url "ietf.group.info.active_groups" group_type="wg" %}">Active WGs</a></li>
18-
<li><a href="{% url "ietf.group.info.active_groups" group_type="rg" %}">Active RGs</a></li>
19-
<li class="dropdown-submenu group-menu"><a href="{% url "ietf.group.info.active_groups" %}">Other</a>{% active_groups_menu %} </li>
17+
<li><a href="{% url "ietf.group.views.active_groups" group_type="wg" %}">Active WGs</a></li>
18+
<li><a href="{% url "ietf.group.views.active_groups" group_type="rg" %}">Active RGs</a></li>
19+
<li class="dropdown-submenu group-menu"><a href="{% url "ietf.group.views.active_groups" %}">Other</a>{% active_groups_menu %} </li>
2020

2121
{% if flavor == "top" %}<li class="divider hidden-xs"></li>{% endif %}
2222
<li {%if flavor == "top" %}class="dropdown-header visible-lg-block"{% else %}class="nav-header hidden-nojs"{% endif %}>By area/parent</li>
@@ -25,12 +25,12 @@
2525

2626
{% if flavor == "top" %}<li class="divider hidden-xs"></li>{% endif %}
2727
<li {%if flavor == "top" %}class="dropdown-header hidden-xs"{% else %}class="nav-header"{% endif %}>New work</li>
28-
<li><a href="{% url "ietf.group.info.chartering_groups" %}">Chartering groups</a></li>
29-
<li><a href="{% url "ietf.group.info.bofs" group_type="wg" %}">BOFs</a></li>
28+
<li><a href="{% url "ietf.group.views.chartering_groups" %}">Chartering groups</a></li>
29+
<li><a href="{% url "ietf.group.views.bofs" group_type="wg" %}">BOFs</a></li>
3030

3131
{% if flavor == "top" %}<li class="divider hidden-xs"></li>{% endif %}
3232
<li {%if flavor == "top" %}class="dropdown-header hidden-xs"{% else %}class="nav-header"{% endif %}>Other groups</li>
33-
<li><a href="{% url "ietf.group.info.concluded_groups" %}">Concluded groups</a></li>
33+
<li><a href="{% url "ietf.group.views.concluded_groups" %}">Concluded groups</a></li>
3434
<li><a href="https://www.ietf.org/list/nonwg.html">Non-WG lists</a></li>
3535

3636
{% if flavor == "top" %}</ul>{% endif %}

0 commit comments

Comments
 (0)